From: tip-bot for Andrey Ryabinin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
kasan-dev@googlegroups.com, kcc@google.com,
akpm@linux-foundation.org, tglx@linutronix.de,
andreyknvl@google.com, glider@google.com,
aryabinin@virtuozzo.com, paulmck@linux.vnet.ibm.com,
dvlasenk@redhat.com, peterz@infradead.org,
sasha.levin@oracle.com, mingo@kernel.org, dvyukov@google.com,
luto@amacapital.net, hpa@zytor.com,
wmglo@dent.med.uni-muenchen.de, bp@alien8.de
Subject: [tip:x86/urgent] x86/mm, kasan: Silence KASAN warnings in get_wchan()
Date: Tue, 20 Oct 2015 02:37:37 -0700 [thread overview]
Message-ID: <tip-f7d27c35ddff7c100d7a98db499ac0040149ac05@git.kernel.org> (raw)
In-Reply-To: <1445243838-17763-3-git-send-email-aryabinin@virtuozzo.com>
Commit-ID: f7d27c35ddff7c100d7a98db499ac0040149ac05
Gitweb: http://git.kernel.org/tip/f7d27c35ddff7c100d7a98db499ac0040149ac05
Author: Andrey Ryabinin <aryabinin@virtuozzo.com>
AuthorDate: Mon, 19 Oct 2015 11:37:18 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Oct 2015 11:04:19 +0200
x86/mm, kasan: Silence KASAN warnings in get_wchan()
get_wchan() is racy by design, it may access volatile stack
of running task, thus it may access redzone in a stack frame
and cause KASAN to warn about this.
Use READ_ONCE_NOCHECK() to silence these warnings.
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Kostya Serebryany <kcc@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>
Cc: kasan-dev <kasan-dev@googlegroups.com>
Link: http://lkml.kernel.org/r/1445243838-17763-3-git-send-email-aryabinin@virtuozzo.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/process.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 39e585a..e28db18 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -550,14 +550,14 @@ unsigned long get_wchan(struct task_struct *p)
if (sp < bottom || sp > top)
return 0;
- fp = READ_ONCE(*(unsigned long *)sp);
+ fp = READ_ONCE_NOCHECK(*(unsigned long *)sp);
do {
if (fp < bottom || fp > top)
return 0;
- ip = READ_ONCE(*(unsigned long *)(fp + sizeof(unsigned long)));
+ ip = READ_ONCE_NOCHECK(*(unsigned long *)(fp + sizeof(unsigned long)));
if (!in_sched_functions(ip))
return ip;
- fp = READ_ONCE(*(unsigned long *)fp);
+ fp = READ_ONCE_NOCHECK(*(unsigned long *)fp);
} while (count++ < 16 && p->state != TASK_RUNNING);
return 0;
}
prev parent reply other threads:[~2015-10-20 9:42 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 12:35 [PATCH v2 0/2] " Andrey Ryabinin
2015-10-13 12:35 ` [PATCH v2 1/2] Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-13 14:16 ` Ingo Molnar
2015-10-13 16:02 ` kbuild test robot
2015-10-13 16:31 ` Andrey Ryabinin
2015-10-14 13:40 ` Ingo Molnar
2015-10-14 14:11 ` Andrey Ryabinin
2015-10-13 12:35 ` [PATCH v2 2/2] x86/process: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-13 13:48 ` Ingo Molnar
2015-10-13 13:57 ` Andrey Ryabinin
2015-10-13 13:57 ` Dmitry Vyukov
2015-10-13 14:15 ` Andrey Ryabinin
2015-10-13 14:19 ` Ingo Molnar
2015-10-13 15:28 ` [PATCH v3 0/2] " Andrey Ryabinin
2015-10-13 15:28 ` [PATCH v3 1/2] Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-14 15:28 ` [tip:locking/urgent] compiler, atomics: Provide READ_ONCE_NOCHECK () tip-bot for Andrey Ryabinin
2015-10-14 15:45 ` Paul E. McKenney
2015-10-14 15:50 ` Dmitry Vyukov
2015-10-14 16:01 ` Paul E. McKenney
2015-10-14 16:08 ` Dmitry Vyukov
2015-10-14 16:16 ` Peter Zijlstra
2015-10-14 16:18 ` Dmitry Vyukov
2015-10-14 16:20 ` Peter Zijlstra
2015-10-14 16:23 ` Andy Lutomirski
2015-10-14 16:34 ` Peter Zijlstra
2015-10-14 17:48 ` Ingo Molnar
2015-10-14 17:57 ` Andy Lutomirski
2015-10-14 16:34 ` Dmitry Vyukov
2015-10-14 16:54 ` Peter Zijlstra
2015-10-14 16:20 ` Paul E. McKenney
2015-10-14 16:32 ` Dmitry Vyukov
2015-10-14 17:04 ` Paul E. McKenney
2015-10-14 17:23 ` Dmitry Vyukov
2015-10-14 17:34 ` Paul E. McKenney
2015-10-14 16:19 ` Andrey Ryabinin
2015-10-14 16:29 ` Dmitry Vyukov
2015-10-14 17:06 ` Paul E. McKenney
2015-10-15 9:18 ` linux-next: build problems (Was: [PATCH v3 1/2] Provide READ_ONCE_NOCHECK()) Stephen Rothwell
2015-10-15 10:03 ` Andrey Ryabinin
2015-10-15 10:19 ` [PATCH] compiler, READ_ONCE: Fix build failure with some older GCC Andrey Ryabinin
2015-10-15 11:30 ` Ingo Molnar
2015-10-13 15:28 ` [PATCH v3 2/2] x86/process: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-14 15:29 ` [tip:locking/urgent] x86/mm: Silence KASAN warnings in get_wchan( ) tip-bot for Andrey Ryabinin
2015-10-16 9:44 ` [PATCH v4 0/2] Andrey Ryabinin
2015-10-16 9:44 ` [PATCH v4 1/2] compiler, atomics: Provide READ_ONCE_NOKSAN() Andrey Ryabinin
2015-10-16 10:00 ` Peter Zijlstra
2015-10-16 10:54 ` Andrey Ryabinin
2015-10-16 11:08 ` Peter Zijlstra
2015-10-16 10:33 ` Borislav Petkov
2015-10-16 11:58 ` Andrey Ryabinin
2015-10-18 7:24 ` Ingo Molnar
2015-10-16 16:05 ` Paul E. McKenney
2015-10-16 9:44 ` [PATCH v4 2/2] x86/mm: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-16 9:47 ` [PATCH v4 0/2] " Andrey Ryabinin
2015-10-19 8:37 ` [PATCH v5 " Andrey Ryabinin
2015-10-19 8:37 ` [PATCH v5 1/2] compiler, atomics: Provide READ_ONCE_NOCHECK() Andrey Ryabinin
2015-10-20 9:37 ` [tip:x86/urgent] compiler, atomics, kasan: " tip-bot for Andrey Ryabinin
2015-10-19 8:37 ` [PATCH v5 2/2] x86/mm: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-20 9:37 ` tip-bot for Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f7d27c35ddff7c100d7a98db499ac0040149ac05@git.kernel.org \
--to=tipbot@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wmglo@dent.med.uni-muenchen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome