mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/smpboot: Remove unused phys_id variable
@ 2019-02-18 13:05 Shaokun Zhang
  2019-02-18 16:34 ` [tip:x86/cleanups] " tip-bot for Shaokun Zhang
  0 siblings, 1 reply; 2+ messages in thread
From: Shaokun Zhang @ 2019-02-18 13:05 UTC (permalink / raw)
  To: x86, linux-kernel
  Cc: Shaokun Zhang, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
	H. Peter Anvin, Igor Mammedov

The 'phys_id' local variable became unused after commit ce4b1b16502b
("x86/smpboot: Initialize secondary CPU only if master CPU will wait for it").
Remove it.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 arch/x86/kernel/smpboot.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index ccd1f2a8e557..5d5421b48e55 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -149,7 +149,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
  */
 static void smp_callin(void)
 {
-	int cpuid, phys_id;
+	int cpuid;
 
 	/*
 	 * If waken up by an INIT in an 82489DX configuration
@@ -160,11 +160,6 @@ static void smp_callin(void)
 	cpuid = smp_processor_id();
 
 	/*
-	 * (This works even if the APIC is not enabled.)
-	 */
-	phys_id = read_apic_id();
-
-	/*
 	 * the boot CPU has finished the init stage and is spinning
 	 * on callin_map until we finish. We are free to set up this
 	 * CPU, first the APIC. (this is probably redundant on most
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/cleanups] x86/smpboot: Remove unused phys_id variable
  2019-02-18 13:05 [PATCH] x86/smpboot: Remove unused phys_id variable Shaokun Zhang
@ 2019-02-18 16:34 ` tip-bot for Shaokun Zhang
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Shaokun Zhang @ 2019-02-18 16:34 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: imammedo, tglx, puwen, x86, suravee.suthikulpanit, bp, mingo,
	zhenzhong.duan, mingo, yazen.ghannam, linux-kernel, zhangshaokun,
	konrad.wilk, rppt, hpa, alison.schofield

Commit-ID:  f91fecc09e498529230b4d5053cb361619a0c42d
Gitweb:     https://git.kernel.org/tip/f91fecc09e498529230b4d5053cb361619a0c42d
Author:     Shaokun Zhang <zhangshaokun@hisilicon.com>
AuthorDate: Mon, 18 Feb 2019 21:05:01 +0800
Committer:  Borislav Petkov <bp@suse.de>
CommitDate: Mon, 18 Feb 2019 17:09:24 +0100

x86/smpboot: Remove unused phys_id variable

The 'phys_id' local variable became unused after commit

  ce4b1b16502b ("x86/smpboot: Initialize secondary CPU only if master CPU will wait for it").

Remove it.

Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Alison Schofield <alison.schofield@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Pu Wen <puwen@hygon.cn>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Link: https://lkml.kernel.org/r/1550495101-41755-1-git-send-email-zhangshaokun@hisilicon.com
---
 arch/x86/kernel/smpboot.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index ccd1f2a8e557..5d5421b48e55 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -149,7 +149,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
  */
 static void smp_callin(void)
 {
-	int cpuid, phys_id;
+	int cpuid;
 
 	/*
 	 * If waken up by an INIT in an 82489DX configuration
@@ -159,11 +159,6 @@ static void smp_callin(void)
 	 */
 	cpuid = smp_processor_id();
 
-	/*
-	 * (This works even if the APIC is not enabled.)
-	 */
-	phys_id = read_apic_id();
-
 	/*
 	 * the boot CPU has finished the init stage and is spinning
 	 * on callin_map until we finish. We are free to set up this

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-18 16:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-18 13:05 [PATCH] x86/smpboot: Remove unused phys_id variable Shaokun Zhang
2019-02-18 16:34 ` [tip:x86/cleanups] " tip-bot for Shaokun Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome