* [PATCH] hw-breakpoints: Fix misordered ifdef
@ 2009-11-23 21:30 Frederic Weisbecker
2009-11-24 7:21 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Frederic Weisbecker @ 2009-11-23 21:30 UTC (permalink / raw)
To: Ingo Molnar
Cc: LKML, Frederic Weisbecker, Prasad, Kisskb-bot by Michael Ellerman
Fix a misplaced ifdef. We need the perf event headers also in off-case
to avoid the following build error:
include/linux/hw_breakpoint.h:94: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:102: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:109: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:116: error: expected declaration specifiers or '...' before 'perf_callback_t'
Reported-by: Kisskb-bot by Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Prasad <prasad@linux.vnet.ibm.com>
---
include/linux/hw_breakpoint.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 76a48ab..c9f7f7c 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -15,10 +15,11 @@ enum {
};
#ifdef __KERNEL__
-#ifdef CONFIG_HAVE_HW_BREAKPOINT
#include <linux/perf_event.h>
+#ifdef CONFIG_HAVE_HW_BREAKPOINT
+
static inline unsigned long hw_breakpoint_addr(struct perf_event *bp)
{
return bp->attr.bp_addr;
--
1.6.2.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip:perf/core] hw-breakpoints: Fix misordered ifdef
2009-11-23 21:30 [PATCH] hw-breakpoints: Fix misordered ifdef Frederic Weisbecker
@ 2009-11-24 7:21 ` tip-bot for Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Frederic Weisbecker @ 2009-11-24 7:21 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, michael, fweisbec, tglx, prasad, mingo
Commit-ID: fa7c27ee9394fc0d52404b2a89882e95868a60b9
Gitweb: http://git.kernel.org/tip/fa7c27ee9394fc0d52404b2a89882e95868a60b9
Author: Frederic Weisbecker <fweisbec@gmail.com>
AuthorDate: Mon, 23 Nov 2009 22:30:12 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 24 Nov 2009 00:09:53 +0100
hw-breakpoints: Fix misordered ifdef
Fix a misplaced ifdef. We need the perf event headers also in
off-case to avoid the following build error:
include/linux/hw_breakpoint.h:94: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:102: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:109: error: expected declaration specifiers or '...' before 'perf_callback_t'
include/linux/hw_breakpoint.h:116: error: expected declaration specifiers or '...' before 'perf_callback_t'
Reported-by: Kisskb-bot by Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Prasad <prasad@linux.vnet.ibm.com>
LKML-Reference: <1259011812-8093-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/hw_breakpoint.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/include/linux/hw_breakpoint.h b/include/linux/hw_breakpoint.h
index 76a48ab..c9f7f7c 100644
--- a/include/linux/hw_breakpoint.h
+++ b/include/linux/hw_breakpoint.h
@@ -15,10 +15,11 @@ enum {
};
#ifdef __KERNEL__
-#ifdef CONFIG_HAVE_HW_BREAKPOINT
#include <linux/perf_event.h>
+#ifdef CONFIG_HAVE_HW_BREAKPOINT
+
static inline unsigned long hw_breakpoint_addr(struct perf_event *bp)
{
return bp->attr.bp_addr;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-24 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-23 21:30 [PATCH] hw-breakpoints: Fix misordered ifdef Frederic Weisbecker
2009-11-24 7:21 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome