* [tip:x86/urgent] x86/MCE: Remove min interval polling limitation
[not found] <20180716084927.24869-1-alexander.sverdlin@nokia.com>
@ 2018-07-17 14:54 ` tip-bot for Dewet Thibaut
2018-07-17 16:00 ` tip-bot for Dewet Thibaut
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot for Dewet Thibaut @ 2018-07-17 14:54 UTC (permalink / raw)
To: linux-tip-commits
Cc: bp, tony.luck, linux-kernel, linux-edac, mingo, tglx,
thibaut.dewet, alexander.sverdlin, hpa
Commit-ID: fd4054b31af283af9ec44895e561bbb3449ad81d
Gitweb: https://git.kernel.org/tip/fd4054b31af283af9ec44895e561bbb3449ad81d
Author: Dewet Thibaut <thibaut.dewet@nokia.com>
AuthorDate: Mon, 16 Jul 2018 10:49:27 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 17 Jul 2018 16:50:17 +0200
x86/MCE: Remove min interval polling limitation
commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min
interval limitation when setting the check interval for polled MCEs.
However, the logic is that 0 disables polling for corrected MCEs, see
Documentation/x86/x86_64/machinecheck. The limitation prevents disabling.
Remove this limitation and allow the value 0 to disable polling again.
Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes")
Signed-off-by: Dewet Thibaut <thibaut.dewet@nokia.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com
---
arch/x86/kernel/cpu/mcheck/mce.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c102ad51025e..8c50754c09c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2165,9 +2165,6 @@ static ssize_t store_int_with_restart(struct device *s,
if (check_interval == old_check_interval)
return ret;
- if (check_interval < 1)
- check_interval = 1;
-
mutex_lock(&mce_sysfs_mutex);
mce_restart();
mutex_unlock(&mce_sysfs_mutex);
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:x86/urgent] x86/MCE: Remove min interval polling limitation
[not found] <20180716084927.24869-1-alexander.sverdlin@nokia.com>
2018-07-17 14:54 ` [tip:x86/urgent] x86/MCE: Remove min interval polling limitation tip-bot for Dewet Thibaut
@ 2018-07-17 16:00 ` tip-bot for Dewet Thibaut
1 sibling, 0 replies; 2+ messages in thread
From: tip-bot for Dewet Thibaut @ 2018-07-17 16:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: thibaut.dewet, alexander.sverdlin, mingo, tony.luck, linux-edac,
bp, linux-kernel, hpa, tglx
Commit-ID: fbdb328c6bae0a7c78d75734a738b66b86dffc96
Gitweb: https://git.kernel.org/tip/fbdb328c6bae0a7c78d75734a738b66b86dffc96
Author: Dewet Thibaut <thibaut.dewet@nokia.com>
AuthorDate: Mon, 16 Jul 2018 10:49:27 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 17 Jul 2018 17:56:25 +0200
x86/MCE: Remove min interval polling limitation
commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min
interval limitation when setting the check interval for polled MCEs.
However, the logic is that 0 disables polling for corrected MCEs, see
Documentation/x86/x86_64/machinecheck. The limitation prevents disabling.
Remove this limitation and allow the value 0 to disable polling again.
Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes")
Signed-off-by: Dewet Thibaut <thibaut.dewet@nokia.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com
---
arch/x86/kernel/cpu/mcheck/mce.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c102ad51025e..8c50754c09c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2165,9 +2165,6 @@ static ssize_t store_int_with_restart(struct device *s,
if (check_interval == old_check_interval)
return ret;
- if (check_interval < 1)
- check_interval = 1;
-
mutex_lock(&mce_sysfs_mutex);
mce_restart();
mutex_unlock(&mce_sysfs_mutex);
^ permalink raw reply [flat|nested] 2+ messages in thread