bkl-removal: drivers/firewire and drivers/ieee1394 patches can be reverted/ dropped

bkl-removal: drivers/firewire and drivers/ieee1394 patches can be reverted/ dropped

[Stefan Richter]

Jonathan,

please revert commits

"firewire: cdev lock_kernel() pushdown"
aabbc0e478bf1e82e7f4a9ec61abb8a1a259175b
http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=aabbc0e478bf1e82e7f4a9ec61abb8a1a259175b

"ieee1394: cdev lock_kernel() pushdown"
8fff9d8cda2b288231fd100333fed26b9bb2042f
http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=8fff9d8cda2b288231fd100333fed26b9bb2042f

and drop them before mainline submission.

I looked at the respective drivers last month and came to the conclusion
that fw_device_op_open(), dv1394_open(), raw1394_open() are safe to be
called without the BKL held.  I specifically looked for possible races
with module initialization or with other processes accessing the
respective character device file interface and found none.

(Well, extremely early openers of dv1394 or raw1394 could find the
devices not yet operational, i.e. they may look to the opener as if no
hardware were present.  But this is no real-world problem.  All actual
application programs which use those device files will in practice
access them only after module initialization was finished and thus be
able to get through to hardware.)

I found a race condition of video1394_open() with module initialization
and fixed it in commit
"ieee1394: video1394: reorder module init, prepare BKL removal"
6ee70088d975130142debdf1f6fe07958d3d2f26
http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=6ee70088d975130142debdf1f6fe07958d3d2f26

Thanks,
-- 
Stefan Richter
-=====-==--- -==- -==--
http://arcgraph.de/sr/

Re: bkl-removal: drivers/firewire and drivers/ieee1394 patches can be reverted/ dropped

[Jonathan Corbet]

On Thu, 12 Jun 2008 22:17:49 +0200 (CEST)
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> please revert commits
> 
> "firewire: cdev lock_kernel() pushdown"
> aabbc0e478bf1e82e7f4a9ec61abb8a1a259175b
> http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=aabbc0e478bf1e82e7f4a9ec61abb8a1a259175b
> 
> "ieee1394: cdev lock_kernel() pushdown"
> 8fff9d8cda2b288231fd100333fed26b9bb2042f
> http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=8fff9d8cda2b288231fd100333fed26b9bb2042f
> 
> and drop them before mainline submission.

Better late than never - those commits are now history.  Thanks for
looking at the code.

jon