CONFIG_VIRT_TO_BUS: what about bus_to_virt?

CONFIG_VIRT_TO_BUS: what about bus_to_virt?

[Stefan Richter]

Is it sensible and safe to let a driver which uses bus_to_virt (but not
virt_to_bus) depend on CONFIG_VIRT_TO_BUS?  Thanks,
-- 
Stefan Richter
-=====-=-=== -=== =-=-=
http://arcgraph.de/sr/

Re: CONFIG_VIRT_TO_BUS: what about bus_to_virt?

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

On Sat, 21 Jul 2007 11:52:18 +0200 Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>
> Is it sensible and safe to let a driver which uses bus_to_virt (but not
> virt_to_bus) depend on CONFIG_VIRT_TO_BUS?

If a driver depends on either bus_to_virt or virt_to_bus, then it
depend on CONFIG_VIRT_TO_BUS.  The intention is to exclude the driver from
being built on achitectures that don't implement those primitives (and
architectures always implement them both or neither).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

[PATCH] ieee1394: sbp2: more correct Kconfig dependencies

[Stefan Richter]

Make the option SBP2_PHYS_DMA available on all architectures where it
compiles.  This includes x86-64 where I runtime-tested it successfully.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

CONFIG_VIRT_TO_BUS is nice.  Thanks Stephen.

--- a/drivers/ieee1394/Kconfig
+++ b/drivers/ieee1394/Kconfig
@@ -97,7 +97,7 @@ config IEEE1394_SBP2
 
 config IEEE1394_SBP2_PHYS_DMA
 	bool "Enable replacement for physical DMA in SBP2"
-	depends on IEEE1394 && IEEE1394_SBP2 && EXPERIMENTAL && (X86_32 || PPC_32)
+	depends on IEEE1394_SBP2 && VIRT_TO_BUS && EXPERIMENTAL
 	help
 	  This builds sbp2 for use with non-OHCI host adapters which do not
 	  support physical DMA or for when ohci1394 is run with phys_dma=0.

-- 
Stefan Richter
-=====-=-=== -=== =-=-=
http://arcgraph.de/sr/