From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jay Fenlason <fenlason@redhat.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] firewire: cdev: fix fw_cdev_event_bus_reset emission after local config ROM changes
Date: Wed, 7 Jul 2010 15:36:07 +0200 (CEST) [thread overview]
Message-ID: <tkrat.46dd12a3a66c6dd7@s5r6.in-berlin.de> (raw)
In-Reply-To: <4C347D4A.9000309@s5r6.in-berlin.de>
When a descriptor was added or removed to the local node's config ROM,
userspace clients which had a local node's /dev/fw* open did not receive
any fw_cdev_event_bus_reset for poll()/read() consumption.
The cause was that the core-device.c facility which re-reads the config
ROM of the bus reset initiator node missed to call the fw_device update
function. The fw_units are destroyed and newly added, but their parent
stays and needs to be updated.
Reported-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/core-device.c | 1 +
1 file changed, 1 insertion(+)
Index: b/drivers/firewire/core-device.c
===================================================================
--- a/drivers/firewire/core-device.c
+++ b/drivers/firewire/core-device.c
@@ -1136,6 +1136,7 @@ static void fw_device_refresh(struct wor
goto give_up;
}
+ fw_device_cdev_update(device);
create_units(device);
/* Userspace may want to re-read attributes. */
--
Stefan Richter
-=====-==-=- -=== --===
http://arcgraph.de/sr/
parent reply other threads:[~2010-07-07 13:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4C347D4A.9000309@s5r6.in-berlin.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.46dd12a3a66c6dd7@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=clemens@ladisch.de \
--cc=fenlason@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®