* [PATCH] firewire: cdev: fix fw_cdev_event_bus_reset emission after local config ROM changes
[not found] ` <4C347D4A.9000309@s5r6.in-berlin.de>
@ 2010-07-07 13:36 ` Stefan Richter
0 siblings, 0 replies; only message in thread
From: Stefan Richter @ 2010-07-07 13:36 UTC (permalink / raw)
To: Jay Fenlason; +Cc: Clemens Ladisch, linux1394-devel, linux-kernel
When a descriptor was added or removed to the local node's config ROM,
userspace clients which had a local node's /dev/fw* open did not receive
any fw_cdev_event_bus_reset for poll()/read() consumption.
The cause was that the core-device.c facility which re-reads the config
ROM of the bus reset initiator node missed to call the fw_device update
function. The fw_units are destroyed and newly added, but their parent
stays and needs to be updated.
Reported-by: Jay Fenlason <fenlason@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/core-device.c | 1 +
1 file changed, 1 insertion(+)
Index: b/drivers/firewire/core-device.c
===================================================================
--- a/drivers/firewire/core-device.c
+++ b/drivers/firewire/core-device.c
@@ -1136,6 +1136,7 @@ static void fw_device_refresh(struct wor
goto give_up;
}
+ fw_device_cdev_update(device);
create_units(device);
/* Userspace may want to re-read attributes. */
--
Stefan Richter
-=====-==-=- -=== --===
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-07 13:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20100511154924.GA11700@redhat.com>
[not found] ` <4BEA56D2.8030902@ladisch.de>
[not found] ` <4BEA5B50.6090701@s5r6.in-berlin.de>
[not found] ` <4C347B28.4040204@s5r6.in-berlin.de>
[not found] ` <4C347D4A.9000309@s5r6.in-berlin.de>
2010-07-07 13:36 ` [PATCH] firewire: cdev: fix fw_cdev_event_bus_reset emission after local config ROM changes Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®