From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: trivial@kernel.org
Cc: Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org, Josh Boyer <jwboyer@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Randy Dunlap <randy.dunlap@oracle.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Robert P. J. Day" <rpjday@mindspring.com>
Subject: [trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat_t
Date: Wed, 30 May 2007 21:01:53 +0200 (CEST) [thread overview]
Message-ID: <tkrat.691ed5f2041a2996@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0705300733200.12382@localhost.localdomain>
On 30 May, Robert P. J. Day wrote:
> On Wed, 30 May 2007, Adrian Bunk wrote:
>> Considering that we export this struct to usespace, I don't think
>> renaming a member without a good reason is a good idea (but adding a
>> comment makes sense).
[...]
> i thought i was submitting a fairly innocuous patch. live and learn.
I've could have seen that it is defined outside #ifdef __KERNEL__.
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: fs: clarify "dummy" member in struct inodes_stat_t
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
--- linux.orig/include/linux/fs.h
+++ linux/include/linux/fs.h
@@ -44,7 +44,7 @@ extern int get_max_files(void);
struct inodes_stat_t {
int nr_inodes;
int nr_unused;
- int dummy[5];
+ int dummy[5]; /* padding for sysctl ABI compatibility */
};
extern struct inodes_stat_t inodes_stat;
--
Stefan Richter
-=====-=-=== -=-= ====-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-05-30 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 17:11 [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t Robert P. J. Day
2007-05-29 18:00 ` Andrew Morton
2007-05-29 18:07 ` Robert P. J. Day
2007-05-29 18:19 ` Randy Dunlap
2007-05-29 18:21 ` Robert P. J. Day
2007-05-29 18:33 ` Randy Dunlap
2007-05-29 18:44 ` Josh Boyer
2007-05-29 19:33 ` Randy Dunlap
2007-05-30 6:41 ` Stefan Richter
2007-05-30 11:29 ` Adrian Bunk
2007-05-30 11:38 ` Robert P. J. Day
2007-05-30 19:01 ` Stefan Richter [this message]
2007-05-30 19:16 ` [trivial PATCH, updated] fs: clarify "dummy" member in struct inodes_stat_t Randy Dunlap
2007-05-29 18:04 ` [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.691ed5f2041a2996@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rpjday@mindspring.com \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®