mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: Ben Collins <bcollins@ubuntu.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.18-rc4-mm1 4/8] ieee1394: sbp2: recheck node generation in sbp2_update
Date: Mon, 14 Aug 2006 19:48:17 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.791447945588f08e@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.9b22090d7dd50b12@s5r6.in-berlin.de>

While sbp2_update() is doing its duties after a bus reset, another reset
could happen.  Don't accept new requests until the next undisturbed
sbp2_update() or until sbp2_remove().

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux/drivers/ieee1394/sbp2.c
===================================================================
--- linux.orig/drivers/ieee1394/sbp2.c	2006-08-14 00:22:32.000000000 +0200
+++ linux/drivers/ieee1394/sbp2.c	2006-08-14 00:27:15.000000000 +0200
@@ -812,11 +812,12 @@ static int sbp2_update(struct unit_direc
 	 */
 	sbp2scsi_complete_all_commands(scsi_id, DID_BUS_BUSY);
 
-	/* Make sure we unblock requests (since this is likely after a bus
-	 * reset). */
-	atomic_set(&scsi_id->unfinished_reset, 0);
-	scsi_unblock_requests(scsi_id->scsi_host);
-
+	/* Accept new commands unless there was another bus reset in the
+	 * meantime. */
+	if (hpsb_node_entry_valid(scsi_id->ne)) {
+		atomic_set(&scsi_id->unfinished_reset, 0);
+		scsi_unblock_requests(scsi_id->scsi_host);
+	}
 	return 0;
 }
 



  parent reply	other threads:[~2006-08-14 17:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 17:40 [PATCH 2.6.18-rc4-mm1 0/8] ieee1394: fixes and touch-ups for sbp2 Stefan Richter
2006-08-14 17:42 ` [PATCH 2.6.18-rc4-mm1 1/8] the scheduled removal of drivers/ieee1394/sbp2.c:force_inquiry_hack Stefan Richter
2006-08-14 17:45 ` [PATCH 2.6.18-rc4-mm1 2/8] ieee1394: sbp2: handle "sbp2util_node_write_no_wait failed" Stefan Richter
2006-08-14 17:47 ` [PATCH 2.6.18-rc4-mm1 3/8] ieee1394: sbp2: safer agent reset in error handlers Stefan Richter
2006-08-14 17:48 ` Stefan Richter [this message]
2006-08-14 17:49 ` [PATCH 2.6.18-rc4-mm1 5/8] ieee1394: sbp2: better handling of transport errors Stefan Richter
2006-08-14 17:50 ` [PATCH 2.6.18-rc4-mm1 6/8] ieee1394: sbp2: select SCSI in Kconfig Stefan Richter
2006-08-14 17:51 ` [PATCH 2.6.18-rc4-mm1 7/8] ieee1394: sbp2: update includes Stefan Richter
2006-08-14 17:53 ` [PATCH 2.6.18-rc4-mm1 8/8] ieee1394: sbp2: prevent rare deadlock in shutdown Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.791447945588f08e@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®