mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: Ben Collins <bcollins@ubuntu.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2.6.18-rc4-mm1 1/8] the scheduled removal of drivers/ieee1394/sbp2.c:force_inquiry_hack
Date: Mon, 14 Aug 2006 19:42:37 +0200 (CEST)	[thread overview]
Message-ID: <tkrat.7dc19850cb95d34b@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.9b22090d7dd50b12@s5r6.in-berlin.de>

Date: Sat, 29 Jul 2006 19:48:28 +0200
From: Adrian Bunk <bunk@stusta.de>
Subject: the scheduled removal of drivers/ieee1394/sbp2.c:force_inquiry_hack

This patch contains the scheduled removal of the force_inquiry_hack 
module parameter.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 Documentation/feature-removal-schedule.txt |    9 ---------
 drivers/ieee1394/sbp2.c                    |   10 ----------
 2 files changed, 19 deletions(-)

Index: linux-2.6.18-rc4-mm1/Documentation/feature-removal-schedule.txt
===================================================================
--- linux-2.6.18-rc4-mm1.orig/Documentation/feature-removal-schedule.txt	2006-08-14 18:12:47.000000000 +0200
+++ linux-2.6.18-rc4-mm1/Documentation/feature-removal-schedule.txt	2006-08-14 18:21:46.000000000 +0200
@@ -23,15 +23,6 @@ Who:	Jody McIntyre <scjody@modernduck.co
 
 ---------------------------
 
-What:	sbp2: module parameter "force_inquiry_hack"
-When:	July 2006
-Why:	Superceded by parameter "workarounds". Both parameters are meant to be
-	used ad-hoc and for single devices only, i.e. not in modprobe.conf,
-	therefore the impact of this feature replacement should be low.
-Who:	Stefan Richter <stefanr@s5r6.in-berlin.de>
-
----------------------------
-
 What:	Video4Linux API 1 ioctls and video_decoder.h from Video devices.
 When:	July 2006
 Why:	V4L1 AP1 was replaced by V4L2 API. during migration from 2.4 to 2.6
Index: linux-2.6.18-rc4-mm1/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.18-rc4-mm1.orig/drivers/ieee1394/sbp2.c	2006-08-14 18:12:59.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/ieee1394/sbp2.c	2006-08-14 18:21:46.000000000 +0200
@@ -174,11 +174,6 @@ MODULE_PARM_DESC(workarounds, "Work arou
 	", override internal blacklist = " __stringify(SBP2_WORKAROUND_OVERRIDE)
 	", or a combination)");
 
-/* legacy parameter */
-static int force_inquiry_hack;
-module_param(force_inquiry_hack, int, 0644);
-MODULE_PARM_DESC(force_inquiry_hack, "Deprecated, use 'workarounds'");
-
 /*
  * Export information about protocols/devices supported by this driver.
  */
@@ -1564,11 +1559,6 @@ static void sbp2_parse_unit_directory(st
 	}
 
 	workarounds = sbp2_default_workarounds;
-	if (force_inquiry_hack) {
-		SBP2_WARN("force_inquiry_hack is deprecated. "
-			  "Use parameter 'workarounds' instead.");
-		workarounds |= SBP2_WORKAROUND_INQUIRY_36;
-	}
 
 	if (!(workarounds & SBP2_WORKAROUND_OVERRIDE))
 		for (i = 0; i < ARRAY_SIZE(sbp2_workarounds_table); i++) {



  reply	other threads:[~2006-08-14 17:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 17:40 [PATCH 2.6.18-rc4-mm1 0/8] ieee1394: fixes and touch-ups for sbp2 Stefan Richter
2006-08-14 17:42 ` Stefan Richter [this message]
2006-08-14 17:45 ` [PATCH 2.6.18-rc4-mm1 2/8] ieee1394: sbp2: handle "sbp2util_node_write_no_wait failed" Stefan Richter
2006-08-14 17:47 ` [PATCH 2.6.18-rc4-mm1 3/8] ieee1394: sbp2: safer agent reset in error handlers Stefan Richter
2006-08-14 17:48 ` [PATCH 2.6.18-rc4-mm1 4/8] ieee1394: sbp2: recheck node generation in sbp2_update Stefan Richter
2006-08-14 17:49 ` [PATCH 2.6.18-rc4-mm1 5/8] ieee1394: sbp2: better handling of transport errors Stefan Richter
2006-08-14 17:50 ` [PATCH 2.6.18-rc4-mm1 6/8] ieee1394: sbp2: select SCSI in Kconfig Stefan Richter
2006-08-14 17:51 ` [PATCH 2.6.18-rc4-mm1 7/8] ieee1394: sbp2: update includes Stefan Richter
2006-08-14 17:53 ` [PATCH 2.6.18-rc4-mm1 8/8] ieee1394: sbp2: prevent rare deadlock in shutdown Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrat.7dc19850cb95d34b@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome