mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2.6.19.y] ieee1394: sbp2: fix probing of some DVD-ROM/RWs
@ 2007-01-11  7:50 Stefan Richter
  0 siblings, 0 replies; only message in thread
From: Stefan Richter @ 2007-01-11  7:50 UTC (permalink / raw)
  To: stable; +Cc: linux-kernel

Since commit 98e238cd42be6c0852da519303cf0182690f8d9f in Linux 2.6.19,
"ieee1394: sbp2: don't prefer MODE SENSE 10", some FireWire DVD-ROMs and
DVD-RWs were mistaken as CD-ROM because sr_mod now sent MODE SENSE 6.
The MMC command set includes only MODE SENSE 10.
http://bugzilla.kernel.org/show_bug.cgi?id=7800

This fix lets sbp2 switch scsi_device.use_10_for_rw on for MMC LUs.
This should rather be done in the command set driver sr_mod, not in the
sbp2 transport driver, and an according patch will follow for a next
Linux release.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
same as commit 1a74bc68e4c0534d150e6454b45a70dab831fa32

Index: linux-2.6.19.1/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.19.1.orig/drivers/ieee1394/sbp2.c
+++ linux-2.6.19.1/drivers/ieee1394/sbp2.c
@@ -2530,6 +2530,8 @@ static int sbp2scsi_slave_configure(stru
 	blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
 	sdev->use_10_for_rw = 1;
 
+	if (sdev->type == TYPE_ROM)
+		sdev->use_10_for_ms = 1;
 	if (sdev->type == TYPE_DISK &&
 	    scsi_id->workarounds & SBP2_WORKAROUND_MODE_SENSE_8)
 		sdev->skip_ms_page_8 = 1;

-- 
Stefan Richter
-=====-=-=== ---= -=-==
http://arcgraph.de/sr/


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-11  7:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-11  7:50 [PATCH 2.6.19.y] ieee1394: sbp2: fix probing of some DVD-ROM/RWs Stefan Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®