mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2.6.22.y.] firewire: fix unloading of fw-ohci while devices are attached
@ 2007-10-10 20:37 Stefan Richter
  0 siblings, 0 replies; only message in thread
From: Stefan Richter @ 2007-10-10 20:37 UTC (permalink / raw)
  To: stable; +Cc: linux-kernel

Fix panic in run_timer_softirq right after "modprobe -r firewire-ohci"
if a FireWire disk was attached and firewire-sbp2 loaded.

Same as commit 8a2d9ed3210464d22fccb9834970629c1c36fa36.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

(I somehow forgot to send this earlier.)

 drivers/firewire/fw-card.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux-2.6.22.10/drivers/firewire/fw-card.c
===================================================================
--- linux-2.6.22.10.orig/drivers/firewire/fw-card.c
+++ linux-2.6.22.10/drivers/firewire/fw-card.c
@@ -507,9 +507,11 @@ fw_core_remove_card(struct fw_card *card
 	/* Set up the dummy driver. */
 	card->driver = &dummy_driver;
 
-	fw_flush_transactions(card);
-
 	fw_destroy_nodes(card);
+	flush_scheduled_work();
+
+	fw_flush_transactions(card);
+	del_timer_sync(&card->flush_timer);
 
 	fw_card_put(card);
 }

-- 
Stefan Richter
-=====-=-=== =-=- -=-=-
http://arcgraph.de/sr/


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-10 20:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-10 20:37 [PATCH 2.6.22.y.] firewire: fix unloading of fw-ohci while devices are attached Stefan Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®