From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] firewire: core: combine a bit of repeated code
Date: Sun, 21 Feb 2010 17:56:42 +0100 (CET) [thread overview]
Message-ID: <tkrat.fb747c7b15b6ff30@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.70de9801677fe5e9@s5r6.in-berlin.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/core-cdev.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
Index: b/drivers/firewire/core-cdev.c
===================================================================
--- a/drivers/firewire/core-cdev.c
+++ b/drivers/firewire/core-cdev.c
@@ -1349,6 +1349,9 @@ static int dispatch_ioctl(struct client
union ioctl_arg buffer;
int ret;
+ if (fw_device_is_shutdown(client->device))
+ return -ENODEV;
+
if (_IOC_TYPE(cmd) != '#' ||
_IOC_NR(cmd) >= ARRAY_SIZE(ioctl_handlers))
return -EINVAL;
@@ -1375,24 +1378,14 @@ static int dispatch_ioctl(struct client
static long fw_device_op_ioctl(struct file *file,
unsigned int cmd, unsigned long arg)
{
- struct client *client = file->private_data;
-
- if (fw_device_is_shutdown(client->device))
- return -ENODEV;
-
- return dispatch_ioctl(client, cmd, (void __user *) arg);
+ return dispatch_ioctl(file->private_data, cmd, (void __user *)arg);
}
#ifdef CONFIG_COMPAT
static long fw_device_op_compat_ioctl(struct file *file,
unsigned int cmd, unsigned long arg)
{
- struct client *client = file->private_data;
-
- if (fw_device_is_shutdown(client->device))
- return -ENODEV;
-
- return dispatch_ioctl(client, cmd, compat_ptr(arg));
+ return dispatch_ioctl(file->private_data, cmd, compat_ptr(arg));
}
#endif
--
Stefan Richter
-=====-==-=- --=- =-=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-02-21 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 16:55 [PATCH 0/8] firewire: misc updates Stefan Richter
2010-02-21 16:56 ` [PATCH 1/8] firewire: core: change type of a data buffer Stefan Richter
2010-02-21 16:56 ` Stefan Richter [this message]
2010-02-21 16:57 ` [PATCH 3/8] firewire: ohci: remove unused dualbuffer IR code Stefan Richter
2010-02-21 16:57 ` [PATCH 4/8] firewire: ohci: reorder struct fw_ohci for better cache efficiency Stefan Richter
2010-02-21 16:58 ` [PATCH 5/8] firewire: ohci: use an ID table for quirks detection Stefan Richter
2010-02-21 16:58 ` [PATCH 6/8] firewire: ohci: add module parameter to activate quirk fixes Stefan Richter
2010-02-21 22:26 ` Stefan Richter
2010-02-21 16:58 ` [PATCH 7/8] firewire: ohci: fix IR/IT context mask mixup Stefan Richter
2010-02-21 16:59 ` [PATCH 8/8] firewire: ohci: extend initialization log message Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.fb747c7b15b6ff30@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®