fix: lp.c wrong return code

fix: lp.c wrong return code

[Walter Harms]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

hi,
how takes care about the lp driver ? i saw some changes in the 2.4 but found no maintainer.
to the maintainer:
LPGETSTATS is strange. first you set LP_STAT then you delete it. maybe a EACCES (Permission denied) would do it ?



problem:
calling the ioctl( LPSETIRQ ) the driver returns EINVAL (Invalid argument)instead of ENOSYS.

Fix : return ENOSYS (Function not implemented)

NOTE:
if EINVAL is correct, you can delete the entiere entry, EINVAL in default.



[-- Attachment #2: lp.diff --]
[-- Type: application/octet-stream, Size: 267 bytes --]

--- lp.c.old	Sun Feb 24 18:19:59 2002
+++ lp.c	Sun Feb 24 18:20:57 2002
@@ -806,7 +806,7 @@
 			LP_WAIT(minor) = arg;
 			break;
 		case LPSETIRQ: 
-			return -EINVAL;
+			return -ENOSYS;
 			break;
 		case LPGETIRQ:
 			if (copy_to_user((int *) arg, &LP_IRQ(minor),

Re: fix: lp.c wrong return code

[Alan Cox]

> calling the ioctl( LPSETIRQ ) the driver returns EINVAL (Invalid argument)instead of ENOSYS.
> Fix : return ENOSYS (Function not implemented)

ENOSYS is for a syscall not supported.

> if EINVAL is correct, you can delete the entiere entry, EINVAL in default.

It should actually be ENOTTY ...