mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: GOTO Masanori <gotom@debian.org>
To: tachino@open.nm.fujitsu.co.jp
Cc: torvalds@transmeta.com, marcelo@conectiva.com.br,
	gotom@debian.org, linux-kernel@vger.kernel.org, andrea@suse.de
Subject: Re: [PATCH] direct IO breaks root filesystem
Date: Wed, 12 Dec 2001 12:25:12 +0900	[thread overview]
Message-ID: <w53lmg9glwn.wl@megaela.fe.dis.titech.ac.jp> (raw)
In-Reply-To: In your message of "Wed, 12 Dec 2001 11:46:29 +0900" <wuzt40l6.wl@nisaaru.dvs.cs.fujitsu.co.jp>
In-Reply-To: <y9k945x1.wl@nisaaru.dvs.cs.fujitsu.co.jp> <Pine.LNX.4.33.0112111742001.18126-100000@penguin.transmeta.com> <wuzt40l6.wl@nisaaru.dvs.cs.fujitsu.co.jp>

At Wed, 12 Dec 2001 11:46:29 +0900,
Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp> wrote:
> At Tue, 11 Dec 2001 17:46:01 -0800 (PST),
> Linus Torvalds wrote:
> > 
> > 
> > On Wed, 12 Dec 2001, Tachino Nobuhiro wrote:
> > >
> > > But my patch fixes another bug. Current /dev/ram* does not return -ENOSPC
> > > at the end of device size because generic_file_write() also checks whether
> > > mapping->host is a block device. So I think the patch is required.
> > 
> > I'll agree with your one-liner: it's good practice anyway to initialize
> > any fields that could ever be looked at. I actually already applied it to
> > my tree, I just want to make sure that people don't apply the other
> > patch..
> > 
> > 		Linus
> 
> Thank you.
> 
> I think the patch should be applied to 2.4 because "dd if=/dev/zero of=/dev/ram1"
> can cause system hang easily.

Linus, Tachino, your patch are both right.
I was not aware mapping inode used block file inode... Umm.

In my test, it works fine for both block device and file, and resolves
"inode->i_dev" and block size problems.
Thank you for your (simple and complete) patch! I'm now happy :)

> Marcelo, please consider applying the patch.

Yes. Would you remove my previous patches and apply these patches ?

Thanks,
-- gotom

  reply	other threads:[~2001-12-12  3:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <w53bsh9ybtn.wl@megaela.fe.dis.titech.ac.jp>
2001-12-10  3:59 ` GOTO Masanori
2001-12-10  5:55   ` Linus Torvalds
2001-12-10 12:39   ` GOTO Masanori
2001-12-10 14:40     ` Andrea Arcangeli
2001-12-10 17:10     ` Linus Torvalds
2001-12-11  9:03     ` GOTO Masanori
2001-12-11  9:13       ` Alexander Viro
2001-12-11 11:30       ` GOTO Masanori
2001-12-11 17:26       ` Linus Torvalds
2001-12-11 17:37       ` Linus Torvalds
2001-12-11 18:03         ` Martin Dalecki
2001-12-12  0:25       ` Tachino Nobuhiro
2001-12-12  0:34         ` Linus Torvalds
2001-12-12  0:51         ` Tachino Nobuhiro
2001-12-12  1:46           ` Linus Torvalds
2001-12-12  3:25             ` GOTO Masanori [this message]
2001-12-12 16:20               ` Marcelo Tosatti
2001-12-12  2:46           ` Tachino Nobuhiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w53lmg9glwn.wl@megaela.fe.dis.titech.ac.jp \
    --to=gotom@debian.org \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=tachino@open.nm.fujitsu.co.jp \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®