From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Daniel Zahka <daniel.zahka@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] psp: refactor psp_dev_tx_key_del()
Date: Sun, 06 Sep 2026 13:08:33 -0400 [thread overview]
Message-ID: <willemdebruijn.kernel.160e8de2976b3@gmail.com> (raw)
In-Reply-To: <20260903-psp-prep-v1-1-d47e9c4c375d@gmail.com>
Daniel Zahka wrote:
> No functional changes.
>
> Lift the list deletion and tx spi validation code into
> callers. Deferred key deletion code paths will need similar checks
> that a tx key needs removal from the underlying device, but will
> diverge when it comes to list handling and when to call
> psp_dev_ops::tx_key_del().
>
> Also, move the predicate for tx key deletion into a helper for
> readability and reuse in later patches.
>
> Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2026-09-06 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 1:33 [PATCH net-next 0/4] psp: make tx key ops optional for drivers Daniel Zahka
2026-09-04 1:33 ` [PATCH net-next 1/4] psp: refactor psp_dev_tx_key_del() Daniel Zahka
2026-09-06 17:08 ` Willem de Bruijn [this message]
2026-09-04 1:34 ` [PATCH net-next 2/4] psp: move code from psp_sock_assoc_set_tx() into helper functions Daniel Zahka
2026-09-06 17:09 ` Willem de Bruijn
2026-09-04 1:34 ` [PATCH net-next 3/4] psp: allow drivers to omit tx key add/del ops Daniel Zahka
2026-09-06 17:09 ` Willem de Bruijn
2026-09-04 1:34 ` [PATCH net-next 4/4] netdevsim: psp: drop tx key ops Daniel Zahka
2026-09-06 17:09 ` Willem de Bruijn
2026-09-08 0:00 ` [PATCH net-next 0/4] psp: make tx key ops optional for drivers patchwork-bot+netdevbpf
2026-09-08 14:09 ` Daniel Zahka
2026-09-08 17:33 ` Jakub Kicinski
2026-09-08 18:58 ` Daniel Zahka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=willemdebruijn.kernel.160e8de2976b3@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®