Re: [PATCH net-next 2/4] psp: move code from psp_sock_assoc_set_tx() into helper functions

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Daniel Zahka wrote:
> No functional changes.
> 
> Lift code that needs to be called from both initial tx establishment
> and tx rekeying into functions that can be reused in both paths.
> 
> The plaintext in recv queue checks and mss adjustment only run on
> initial tx keying. The dummy psp_assoc machinery will be used in both
> paths.
> 
> psp_dev_tx_key_add() absorbs the dummy assoc machinery, as its main
> purpose is to populate the device specific psp_assoc:drv_data.
> 
> psp_assoc_set_tx() exists so that a future change can allow
> psp_dev_tx_key_add() to be skipped entirely for devices that don't use
> an SADB, while copying of the tx spi and key into the assoc needs to
> happen regardless of SADB vs. no SADB.
> 
> Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>