mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
	linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: fix sparse warning
Date: Tue, 26 May 2015 10:10:21 -0400	[thread overview]
Message-ID: <wrfjegm34egi.fsf@ultrasam.lan.trained-monkey.org> (raw)
In-Reply-To: <1432357384-16665-1-git-send-email-juston.h.li@gmail.com> (Juston Li's message of "Fri, 22 May 2015 22:03:04 -0700")

Juston Li <juston.h.li@gmail.com> writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16
>
> Signed-off-by: Juston Li <juston.h.li@gmail.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks OK to me

Jes

>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index 04d0183..e23af8e 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -1485,7 +1485,7 @@ void Hal_EfuseParseIDCode(struct rtw_adapter *padapter, u8 *hwinfo)
>  	u16 EEPROMId;
>  
>  	/*  Checl 0x8129 again for making sure autoload status!! */
> -	EEPROMId = le16_to_cpu(*((u16 *) hwinfo));
> +	EEPROMId = le16_to_cpu(*((__le16 *) hwinfo));
>  	if (EEPROMId != RTL_EEPROM_ID) {
>  		DBG_8723A("EEPROM ID(%#x) is invalid!!\n", EEPROMId);
>  		pEEPROM->bautoload_fail_flag = true;

  reply	other threads:[~2015-05-26 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23  5:03 Juston Li
2015-05-26 14:10 ` Jes Sorensen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-06-24 20:57 Clement Calmels
2014-06-24 22:07 ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wrfjegm34egi.fsf@ultrasam.lan.trained-monkey.org \
    --to=jes.sorensen@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=juston.h.li@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®