[PATCH] staging: rtl8723au: fix sparse warning

[PATCH] staging: rtl8723au: fix sparse warning

[Juston Li]

change cast to __le16 to fix the following warning:
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16

Signed-off-by: Juston Li <juston.h.li@gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index 04d0183..e23af8e 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
@@ -1485,7 +1485,7 @@ void Hal_EfuseParseIDCode(struct rtw_adapter *padapter, u8 *hwinfo)
 	u16 EEPROMId;
 
 	/*  Checl 0x8129 again for making sure autoload status!! */
-	EEPROMId = le16_to_cpu(*((u16 *) hwinfo));
+	EEPROMId = le16_to_cpu(*((__le16 *) hwinfo));
 	if (EEPROMId != RTL_EEPROM_ID) {
 		DBG_8723A("EEPROM ID(%#x) is invalid!!\n", EEPROMId);
 		pEEPROM->bautoload_fail_flag = true;
-- 
2.4.1

Re: [PATCH] staging: rtl8723au: fix sparse warning

[Jes Sorensen]

Juston Li <juston.h.li@gmail.com> writes:
> change cast to __le16 to fix the following warning:
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16
>
> Signed-off-by: Juston Li <juston.h.li@gmail.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks OK to me

Jes

>
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> index 04d0183..e23af8e 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> @@ -1485,7 +1485,7 @@ void Hal_EfuseParseIDCode(struct rtw_adapter *padapter, u8 *hwinfo)
>  	u16 EEPROMId;
>  
>  	/*  Checl 0x8129 again for making sure autoload status!! */
> -	EEPROMId = le16_to_cpu(*((u16 *) hwinfo));
> +	EEPROMId = le16_to_cpu(*((__le16 *) hwinfo));
>  	if (EEPROMId != RTL_EEPROM_ID) {
>  		DBG_8723A("EEPROM ID(%#x) is invalid!!\n", EEPROMId);
>  		pEEPROM->bautoload_fail_flag = true;

[PATCH] staging: rtl8723au: fix sparse warning

[Clement Calmels]

From: Clément Calmels <clement.calmels@free.fr>

Found running sparse on the rtl8723au driver.

  CHECK   drivers/staging/rtl8723au/core/rtw_cmd.c
drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in argument 2 (different base types)
drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:    expected int [signed] gfp
drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:    got restricted gfp_t

Signed-off-by: Clement Calmels <clement.calmels@free.fr>
---
 drivers/staging/rtl8723au/core/rtw_mlme.c    | 2 +-
 drivers/staging/rtl8723au/include/rtw_mlme.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c
index 7170258..c6f4e47 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723au/core/rtw_mlme.c
@@ -125,7 +125,7 @@ void rtw_free_mlme_priv23a(struct mlme_priv *pmlmepriv)
 	rtw23a_free_mlme_priv_ie_data(pmlmepriv);
 }
 
-struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv, int gfp)
+struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv, gfp_t gfp)
 {
 	struct wlan_network *pnetwork;
 
diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h b/drivers/staging/rtl8723au/include/rtw_mlme.h
index 4d327ba..f798078 100644
--- a/drivers/staging/rtl8723au/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723au/include/rtw_mlme.h
@@ -344,7 +344,7 @@ void rtw23a_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv);
 
 void _rtw_free_mlme_priv23a(struct mlme_priv *pmlmepriv);
 
-struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv, int gfp);
+struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv, gfp_t gfp);
 
 int rtw_if_up23a(struct rtw_adapter *padapter);
 
-- 
2.0.0

Re: [PATCH] staging: rtl8723au: fix sparse warning

[Jes Sorensen]

Clement Calmels <clement.calmels@free.fr> writes:
> From: Clément Calmels <clement.calmels@free.fr>
>
> Found running sparse on the rtl8723au driver.
>
>   CHECK   drivers/staging/rtl8723au/core/rtw_cmd.c
> drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in argument 2 (different base types)
> drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:    expected int [signed] gfp
> drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:    got restricted gfp_t
>
> Signed-off-by: Clement Calmels <clement.calmels@free.fr>
> ---
>  drivers/staging/rtl8723au/core/rtw_mlme.c    | 2 +-
>  drivers/staging/rtl8723au/include/rtw_mlme.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, I'll add it to my tree!

Cheers,
Jes