From: Jeff Moyer <jmoyer@redhat.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] umem: fix error return code
Date: Thu, 07 Aug 2014 17:41:29 -0400 [thread overview]
Message-ID: <x491tssasfq.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1407445067-4044-3-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Thu, 7 Aug 2014 22:57:45 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> diff --git a/drivers/block/umem.c b/drivers/block/umem.c
> index 4cf81b5..371e819 100644
> --- a/drivers/block/umem.c
> +++ b/drivers/block/umem.c
> @@ -881,6 +881,7 @@ static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> if (card->mm_pages[0].desc == NULL ||
> card->mm_pages[1].desc == NULL) {
> dev_printk(KERN_ERR, &card->dev->dev, "alloc failed\n");
> + ret = -ENOMEM;
> goto failed_alloc;
> }
> reset_page(&card->mm_pages[0]);
> @@ -891,8 +892,10 @@ static int mm_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> card->biotail = &card->bio;
>
> card->queue = blk_alloc_queue(GFP_KERNEL);
> - if (!card->queue)
> + if (!card->queue) {
> + ret = -ENOMEM;
> goto failed_alloc;
> + }
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2014-08-07 21:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:57 [PATCH 0/4] " Julia Lawall
2014-08-07 20:57 ` [PATCH 2/4] gdrom: " Julia Lawall
2014-08-07 21:41 ` Jeff Moyer
2014-08-07 20:57 ` [PATCH 1/4] umem: " Julia Lawall
2014-08-07 21:41 ` Jeff Moyer [this message]
2014-08-07 20:57 ` [PATCH 3/4] block: " Julia Lawall
2014-08-07 21:48 ` Jeff Moyer
2014-08-08 4:58 ` Julia Lawall
2014-08-08 9:21 ` Dan Carpenter
2014-08-07 20:57 ` [PATCH 4/4] usb: gadget: " Julia Lawall
2014-08-07 21:50 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x491tssasfq.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®