From: Jeff Moyer <jmoyer@redhat.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] gdrom: fix error return code
Date: Thu, 07 Aug 2014 17:41:54 -0400 [thread overview]
Message-ID: <x49wqak9dul.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1407445067-4044-2-git-send-email-Julia.Lawall@lip6.fr> (Julia Lawall's message of "Thu, 7 Aug 2014 22:57:44 +0200")
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
> index 584bc31..46ecd95 100644
> --- a/drivers/cdrom/gdrom.c
> +++ b/drivers/cdrom/gdrom.c
> @@ -807,16 +807,20 @@ static int probe_gdrom(struct platform_device *devptr)
> if (err)
> goto probe_fail_cmdirq_register;
> gd.gdrom_rq = blk_init_queue(gdrom_request, &gdrom_lock);
> - if (!gd.gdrom_rq)
> + if (!gd.gdrom_rq) {
> + err = -ENOMEM;
> goto probe_fail_requestq;
> + }
>
> err = probe_gdrom_setupqueue();
> if (err)
> goto probe_fail_toc;
>
> gd.toc = kzalloc(sizeof(struct gdromtoc), GFP_KERNEL);
> - if (!gd.toc)
> + if (!gd.toc) {
> + err = -ENOMEM;
> goto probe_fail_toc;
> + }
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2014-08-07 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:57 [PATCH 0/4] " Julia Lawall
2014-08-07 20:57 ` [PATCH 2/4] gdrom: " Julia Lawall
2014-08-07 21:41 ` Jeff Moyer [this message]
2014-08-07 20:57 ` [PATCH 1/4] umem: " Julia Lawall
2014-08-07 21:41 ` Jeff Moyer
2014-08-07 20:57 ` [PATCH 3/4] block: " Julia Lawall
2014-08-07 21:48 ` Jeff Moyer
2014-08-08 4:58 ` Julia Lawall
2014-08-08 9:21 ` Dan Carpenter
2014-08-07 20:57 ` [PATCH 4/4] usb: gadget: " Julia Lawall
2014-08-07 21:50 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49wqak9dul.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®