[patch] skd: add build dependency on HARDIRQ

[patch] skd: add build dependency on HARDIRQ

[Jeff Moyer]

Hi,

This driver won't build on architectures without generic hardirq
support.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>

diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
index 014a1cf..f3a5300 100644
--- a/drivers/block/Kconfig
+++ b/drivers/block/Kconfig
@@ -325,6 +325,7 @@ config BLK_DEV_SKD
 	tristate "STEC S1120 Block Driver"
 	depends on PCI
 	depends on 64BIT
+	depends on GENERIC_HARDIRQS
 	---help---
 	Saying Y or M here will enable support for the
 	STEC, Inc. S1120 PCIe SSD.

Re: [patch] skd: add build dependency on HARDIRQ

[Geert Uytterhoeven]

Hi Jeff,

On Mon, Aug 11, 2014 at 10:46 PM, Jeff Moyer <jmoyer@redhat.com> wrote:
> This driver won't build on architectures without generic hardirq
> support.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 014a1cf..f3a5300 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -325,6 +325,7 @@ config BLK_DEV_SKD
>         tristate "STEC S1120 Block Driver"
>         depends on PCI
>         depends on 64BIT
> +       depends on GENERIC_HARDIRQS
>         ---help---
>         Saying Y or M here will enable support for the
>         STEC, Inc. S1120 PCIe SSD.

Which kernel version does this apply to?

GENERIC_HARDIRQS was removed in
commit 0244ad004a54e39308d495fee0a2e637f8b5c317
Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
Date:   Fri Aug 30 09:39:53 2013 +0200

    Remove GENERIC_HARDIRQ config option

    After the last architecture switched to generic hard irqs the config
    options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
    for !CONFIG_GENERIC_HARDIRQS can be removed.

    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

after it became supported by all architectures.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [patch] skd: add build dependency on HARDIRQ

[Jeff Moyer]

Geert Uytterhoeven <geert@linux-m68k.org> writes:

Hi, Geer,

> Which kernel version does this apply to?
>
> GENERIC_HARDIRQS was removed in
> commit 0244ad004a54e39308d495fee0a2e637f8b5c317
> Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Date:   Fri Aug 30 09:39:53 2013 +0200
>
>     Remove GENERIC_HARDIRQ config option
>
>     After the last architecture switched to generic hard irqs the config
>     options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
>     for !CONFIG_GENERIC_HARDIRQS can be removed.
>
>     Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> after it became supported by all architectures.

Ah, thanks for pointing that out.  I needed the patch on an older (3.10
based) kernel and didn't realize it wasn't needed any more.  Sorry for
the noise!

Cheers,
Jeff