mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Corrado Zoccolo <czoccolo@gmail.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	aaronc@gelato.unsw.edu.au
Subject: Re: [RFC, PATCH] cfq-iosched: remove redundant queuing detection code
Date: Tue, 10 Nov 2009 10:55:47 -0500	[thread overview]
Message-ID: <x49fx8m5q7w.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20091110154809.GL8742@kernel.dk> (Jens Axboe's message of "Tue, 10 Nov 2009 16:48:09 +0100")

Jens Axboe <jens.axboe@oracle.com> writes:

>> Why don't we simply use the value configured via the queue_depth sysfs
>> file?
>
> First of all, that only covers SCSI. We could do that by having the tag
> on/off functions set the same flag. But even for such devices, actual
> tag depth is dependent upon what other devices are on the controller
> (since it's often a shared map) and may not even be statically
> detectable in the sense that actual depth is only really seen when the
> device returns busy on a queue attempt.
>
> In most cases it would work fine, but the dynamic detection is more
> reliable. The sysfs setting in reality is max setting.

OK, thanks for the patient explanation, Jens!

Cheers,
Jeff

  reply	other threads:[~2009-11-10 15:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 13:54 Corrado Zoccolo
2009-11-10 15:03 ` Jeff Moyer
2009-11-10 15:14 ` Jens Axboe
2009-11-10 15:20   ` Jeff Moyer
2009-11-10 15:27     ` Jens Axboe
2009-11-10 15:41       ` Jeff Moyer
2009-11-10 15:48         ` Jens Axboe
2009-11-10 15:55           ` Jeff Moyer [this message]
2009-11-10 17:56   ` Corrado Zoccolo
2009-11-12 12:16     ` Jens Axboe
2009-11-12 13:14       ` Corrado Zoccolo
2009-11-12 13:16         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49fx8m5q7w.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=aaronc@gelato.unsw.edu.au \
    --cc=czoccolo@gmail.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®