From: Jeff Moyer <jmoyer@redhat.com>
To: Corrado Zoccolo <czoccolo@gmail.com>
Cc: "Linux-Kernel" <linux-kernel@vger.kernel.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [RFC, PATCH] cfq-iosched: remove redundant queuing detection code
Date: Tue, 10 Nov 2009 10:03:32 -0500 [thread overview]
Message-ID: <x49vdhi5smz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <200911101454.57522.czoccolo@gmail.com> (Corrado Zoccolo's message of "Tue, 10 Nov 2009 14:54:57 +0100")
Corrado Zoccolo <czoccolo@gmail.com> writes:
> The core block layer already has code to detect presence of command
> queuing devices. We convert cfq to use that instead of re-doing the
> computation.
This sounds like a good idea to me, and it appears the same number of
requests will be used to detect command queuing. I'm surprised we can't
just query each device to detect this, honestly.
One thing you missed, though, was removing the CFQ_HW_QUEUE_MIN define.
Cheers,
Jeff
next prev parent reply other threads:[~2009-11-10 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 13:54 Corrado Zoccolo
2009-11-10 15:03 ` Jeff Moyer [this message]
2009-11-10 15:14 ` Jens Axboe
2009-11-10 15:20 ` Jeff Moyer
2009-11-10 15:27 ` Jens Axboe
2009-11-10 15:41 ` Jeff Moyer
2009-11-10 15:48 ` Jens Axboe
2009-11-10 15:55 ` Jeff Moyer
2009-11-10 17:56 ` Corrado Zoccolo
2009-11-12 12:16 ` Jens Axboe
2009-11-12 13:14 ` Corrado Zoccolo
2009-11-12 13:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49vdhi5smz.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®