From: Jeff Moyer <jmoyer@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, vgoyal@redhat.com,
avanzini.arianna@gmail.com
Subject: Re: [PATCH 4/8] cfq-iosched: minor cleanups
Date: Mon, 08 Jun 2015 14:59:49 -0400 [thread overview]
Message-ID: <x49ioayhvq2.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1433753973-23684-5-git-send-email-tj@kernel.org> (Tejun Heo's message of "Mon, 8 Jun 2015 17:59:29 +0900")
Tejun Heo <tj@kernel.org> writes:
> * Some were accessing cic->cfqq[] directly. Always use cic_to_cfqq()
> and cic_set_cfqq().
>
> * check_ioprio_changed() doesn't need to verify cfq_get_queue()'s
> return for NULL. It's always non-NULL. Simplify accordingly.
>
> This patch doesn't cause any functional changes.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Arianna Avanzini <avanzini.arianna@gmail.com>
Looks good. I don't much like the "bool is_sync" function parameters.
Calls to cic_to_cfqq, cic_set_cfqq, etc would be much easier to read if
they took BLK_RW_SYNC and BLK_RW_ASYNC. Certainly not a problem with
this patch, though, just a general observation.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2015-06-08 18:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 8:59 [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs Tejun Heo
2015-06-08 8:59 ` [PATCH 1/8] cfq-iosched: simplify control flow in cfq_get_queue() Tejun Heo
2015-06-08 18:36 ` Jeff Moyer
2015-06-08 8:59 ` [PATCH 2/8] cfq-iosched: fix async oom queue handling Tejun Heo
2015-06-08 18:42 ` Jeff Moyer
2015-06-08 8:59 ` [PATCH 3/8] cfq-iosched: fix oom cfq_queue ref leak in cfq_set_request() Tejun Heo
2015-06-08 18:51 ` Jeff Moyer
2015-06-08 8:59 ` [PATCH 4/8] cfq-iosched: minor cleanups Tejun Heo
2015-06-08 18:59 ` Jeff Moyer [this message]
2015-06-08 8:59 ` [PATCH 5/8] cfq-iosched: remove @gfp_mask from cfq_find_alloc_queue() Tejun Heo
2015-06-08 19:24 ` Jeff Moyer
2015-06-08 20:27 ` Jeff Moyer
2015-06-08 21:19 ` Vivek Goyal
2015-06-09 3:01 ` Tejun Heo
2015-06-09 3:00 ` Tejun Heo
2015-06-09 14:29 ` Jeff Moyer
2015-06-08 8:59 ` [PATCH 6/8] cfq-iosched: move cfq_group determination from cfq_find_alloc_queue() to cfq_get_queue() Tejun Heo
2015-06-09 14:32 ` Jeff Moyer
2015-06-08 8:59 ` [PATCH 7/8] cfq-iosched: fold cfq_find_alloc_queue() into cfq_get_queue() Tejun Heo
2015-06-09 14:40 ` Jeff Moyer
2015-06-10 2:47 ` Tejun Heo
2015-06-08 8:59 ` [PATCH 8/8] cfq-iosched: charge async IOs to the appropriate blkcg's instead of the root Tejun Heo
2015-06-08 22:29 ` Vivek Goyal
2015-06-09 3:11 ` Tejun Heo
2015-06-09 15:03 ` Jeff Moyer
2015-06-08 19:49 ` [PATCHSET block/for-4.2/writeback] block, cgroup: make cfq charge async IOs to the appropriate blkcgs Jeff Moyer
2015-06-09 3:03 ` Tejun Heo
2015-06-09 15:05 ` Jeff Moyer
2015-06-10 2:49 ` Tejun Heo
2015-06-09 4:21 ` [PATCH 4.5/8] blkcg, cfq-iosched: use GFP_NOWAIT instead of GFP_ATOMIC for non-critical allocations Tejun Heo
2015-06-09 14:27 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49ioayhvq2.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®