From: Jeff Moyer <jmoyer@redhat.com>
To: Nikolay Borisov <nborisov@suse.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO
Date: Thu, 03 Aug 2017 10:08:57 -0400 [thread overview]
Message-ID: <x49o9rwvj46.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1501657852-12603-1-git-send-email-nborisov@suse.com> (Nikolay Borisov's message of "Wed, 2 Aug 2017 10:10:52 +0300")
Nikolay Borisov <nborisov@suse.com> writes:
> We already get the block counts and the calculate the end block at the
> beginning of the function. Let's use the local variables for consistency and
> readability. No functional changes
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Looks ok to me.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2017-08-03 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 7:10 Nikolay Borisov
2017-08-03 14:08 ` Jeff Moyer [this message]
2017-09-15 19:34 ` Nikolay Borisov
2018-02-21 17:48 ` Nikolay Borisov
2018-02-26 9:54 Nikolay Borisov
2018-03-03 0:24 ` Andrew Morton
2018-03-03 8:16 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49o9rwvj46.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®