From: Jeff Moyer <jmoyer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@fb.com>, Alexander Graf <agraf@suse.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <tom.leiming@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity
Date: Fri, 13 Nov 2015 15:59:52 -0500 [thread overview]
Message-ID: <x49si494nuf.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1447143190-44589-3-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Tue, 10 Nov 2015 09:13:08 +0100")
Hannes Reinecke <hare@suse.de> writes:
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Introduced by the code refactoring in 7b0576a3d835b4d46ed85d817ce016e90bf293a3.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> ---
> drivers/block/loop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index e790487..7272055 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1310,7 +1310,7 @@ loop_get_status64(struct loop_device *lo, struct loop_info64 __user *arg) {
> return err;
> }
>
> -static int loop_set_capacity(struct loop_device *lo, struct block_device *bdev)
> +static int loop_set_capacity(struct loop_device *lo)
> {
> if (unlikely(lo->lo_state != Lo_bound))
> return -ENXIO;
> @@ -1373,7 +1373,7 @@ static int lo_ioctl(struct block_device *bdev, fmode_t mode,
> case LOOP_SET_CAPACITY:
> err = -EPERM;
> if ((mode & FMODE_WRITE) || capable(CAP_SYS_ADMIN))
> - err = loop_set_capacity(lo, bdev);
> + err = loop_set_capacity(lo);
> break;
> case LOOP_SET_DIRECT_IO:
> err = -EPERM;
next prev parent reply other threads:[~2015-11-13 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 8:13 [PATCHv3 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-11-10 8:13 ` [PATCH 1/4] loop: Enable correct physical blocksize Hannes Reinecke
2015-11-13 20:57 ` Jeff Moyer
2015-12-01 9:32 ` Hannes Reinecke
2015-11-20 3:12 ` Ming Lei
2015-11-10 8:13 ` [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke
2015-11-13 20:59 ` Jeff Moyer [this message]
2015-11-10 8:13 ` [PATCH 3/4] loop: Add 'lo_logical_blocksize' Hannes Reinecke
2015-11-10 8:13 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
2015-11-13 21:42 ` Jeff Moyer
-- strict thread matches above, loose matches on Subject: below --
2015-07-17 7:27 [PATCH 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-07-17 7:27 ` [PATCH 2/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke
2015-07-27 5:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49si494nuf.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=agraf@suse.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®