From: Valentin Schneider <vschneid@redhat.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Ionela Voinescu <ionela.voinescu@arm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ricardo Neri <ricardo.neri@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Ben Segall <bsegall@google.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Len Brown <len.brown@intel.com>, Mel Gorman <mgorman@suse.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
"Tim C . Chen" <tim.c.chen@intel.com>
Subject: Re: [PATCH v2 5/7] x86/sched: Remove SD_ASYM_PACKING from the "SMT" domain
Date: Tue, 10 Jan 2023 19:17:51 +0000 [thread overview]
Message-ID: <xhsmh1qo2dwrk.mognet@vschneid.remote.csb> (raw)
In-Reply-To: <20221229190249.GA14462@ranerica-svr.sc.intel.com>
On 29/12/22 11:02, Ricardo Neri wrote:
> On Thu, Dec 22, 2022 at 04:56:51PM +0000, Valentin Schneider wrote:
>> diff --git a/include/linux/sched/sd_flags.h b/include/linux/sched/sd_flags.h
>> index 57bde66d95f7a..8dc16942135b4 100644
>> --- a/include/linux/sched/sd_flags.h
>> +++ b/include/linux/sched/sd_flags.h
>> @@ -132,12 +132,12 @@ SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS)
>> /*
>> * Place busy tasks earlier in the domain
>> *
>> - * SHARED_CHILD: Usually set on the SMT level. Technically could be set further
>> - * up, but currently assumed to be set from the base domain
>> - * upwards (see update_top_cache_domain()).
>> + * SHARED_PARENT: Usually set on the SMT level. Can be set further up if all
>> + * siblings of an SMT core are identical, but SMT cores themselves
>> + * have different priorites.
>> * NEEDS_GROUPS: Load balancing flag.
>> */
>> -SD_FLAG(SD_ASYM_PACKING, SDF_SHARED_CHILD | SDF_NEEDS_GROUPS)
>> +SD_FLAG(SD_ASYM_PACKING, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS)
>
> But this would not work for Power7. It only has SD_ASYM_PACKING in the SMT
> sched domain. Must it have either of these flags?
>
It's not mandatory, but making sure SD flags conform to either of them
means the topology debugging infra can help spot misshapen topologies...
> In Power7 SMT siblings have the different priority but, IIUC, physical
> cores are identical.
>
...But you're right, this doesn't work with Power7 as it would need
SD_ASYM_PACKING all the way up the topology to conform with
SDF_SHARED_PARENT, which clearly doesn't work with how Power7 uses
asym_packing.
> It seems to me that asym_packing is specific to a domain.
>
For Power7 it is, since the asymmetry is only between siblings of a given
core. For other systems where the asymmetry is between cores, that could
theoretically affect several levels. Consider:
DIE [ ]
MC [ ][ ]
SMT [ ][ ][ ][ ]
CPU 0 1 2 3 4 5 6 7
prio 3 3 2 2 1 1 0 0
As done in your patch, here asym_packing doesn't make sense for SMT, but it
does for MC and DIE.
Anywho, I think what this means if we should drop the SDF_SHARED_* metaflag
for SD_ASYM_PACKING, unless we can think of a nice way to programmatically
describe how SD_ASYM_PACKING should be set.
> Thanks and BR,
> Ricardo
next prev parent reply other threads:[~2023-01-10 19:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:35 [PATCH v2 0/7] x86/sched: Avoid unnecessary migrations within SMT domains Ricardo Neri
2022-11-22 20:35 ` [PATCH v2 1/7] sched/fair: Generalize asym_packing logic for SMT local sched group Ricardo Neri
2022-12-06 17:22 ` Dietmar Eggemann
2022-12-12 17:53 ` Ricardo Neri
2022-12-21 13:03 ` Dietmar Eggemann
2022-12-22 4:32 ` Ricardo Neri
2022-12-22 11:12 ` Dietmar Eggemann
2022-12-23 13:11 ` Ricardo Neri
2022-12-22 16:55 ` Valentin Schneider
2022-12-29 4:00 ` Ricardo Neri
2023-01-11 16:04 ` Valentin Schneider
2023-01-13 19:02 ` Ricardo Neri
2023-01-16 4:05 ` Ricardo Neri
2023-01-16 19:07 ` Valentin Schneider
2023-01-17 12:49 ` Ricardo Neri
2022-11-22 20:35 ` [PATCH v2 2/7] sched: Prepare sched_asym_prefer() to handle idle state of SMT siblings Ricardo Neri
2022-11-22 20:35 ` [PATCH v2 3/7] sched: Teach arch_asym_cpu_priority() the " Ricardo Neri
2022-12-06 17:54 ` Dietmar Eggemann
2022-12-12 17:54 ` Ricardo Neri
2022-12-21 17:12 ` Dietmar Eggemann
2022-12-22 4:55 ` Ricardo Neri
2022-12-22 16:56 ` Valentin Schneider
2022-11-22 20:35 ` [PATCH v2 4/7] sched/fair: Introduce sched_smt_siblings_idle() Ricardo Neri
2022-12-06 18:03 ` Dietmar Eggemann
2022-12-12 17:54 ` Ricardo Neri
2022-12-22 11:12 ` Dietmar Eggemann
2022-12-22 16:56 ` Valentin Schneider
2022-12-24 5:28 ` Ricardo Neri
2022-12-28 15:29 ` Chen Yu
2022-12-30 0:17 ` Ricardo Neri
2023-01-10 19:21 ` Valentin Schneider
2022-11-22 20:35 ` [PATCH v2 5/7] x86/sched: Remove SD_ASYM_PACKING from the "SMT" domain Ricardo Neri
2022-12-08 16:03 ` Ionela Voinescu
2022-12-14 16:59 ` Ricardo Neri
2022-12-15 16:48 ` Valentin Schneider
2022-12-20 0:42 ` Ricardo Neri
2022-12-22 16:56 ` Valentin Schneider
2022-12-29 19:02 ` Ricardo Neri
2023-01-10 19:17 ` Valentin Schneider [this message]
2023-01-13 1:31 ` Ricardo Neri
2022-11-22 20:35 ` [PATCH v2 6/7] x86/sched/itmt: Give all SMT siblings of a core the same priority Ricardo Neri
2022-11-22 20:35 ` [PATCH v2 7/7] x86/sched/itmt: Consider the idle state of SMT siblings Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhsmh1qo2dwrk.mognet@vschneid.remote.csb \
--to=vschneid@redhat.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=juri.lelli@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tim.c.chen@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®