From: Valentin Schneider <vschneid@redhat.com>
To: Pierre Gondois <pierre.gondois@arm.com>,
Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
Cc: dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
ionela.voinescu@arm.com, quentin.perret@arm.com,
srikar@linux.vnet.ibm.com, mgorman@techsingularity.net,
mingo@kernel.org, yu.c.chen@intel.com,
tim.c.chen@linux.intel.com, mingo@redhat.com,
peterz@infradead.org, vincent.guittot@linaro.org
Subject: Re: [PATCH v3] sched/topology: remove sysctl_sched_energy_aware depending on the architecture
Date: Mon, 18 Sep 2023 14:21:01 +0200 [thread overview]
Message-ID: <xhsmhbkdzvfiq.mognet@vschneid.remote.csb> (raw)
In-Reply-To: <ff3a1e32-74c3-56bc-94dc-78d088faf8b7@arm.com>
On 15/09/23 15:35, Pierre Gondois wrote:
> Hello Valentin,
>
> On 9/15/23 14:00, Valentin Schneider wrote:
>> On 14/09/23 23:26, Shrikanth Hegde wrote:
>>> On 9/14/23 9:51 PM, Valentin Schneider wrote:
>>>> On 13/09/23 17:18, Shrikanth Hegde wrote:
>>>>> sysctl_sched_energy_aware is available for the admin to disable/enable
>>>>> energy aware scheduling(EAS). EAS is enabled only if few conditions are
>>>>> met by the platform. They are, asymmetric CPU capacity, no SMT,
>>>>> valid cpufreq policy, frequency invariant load tracking. It is possible
>>>>> platform when booting may not have EAS capability, but can do that after.
>>>>> For example, changing/registering the cpufreq policy.
>>>>>
>>>>> At present, though platform doesn't support EAS, this sysctl is still
>>>>> present and it ends up calling rebuild of sched domain on write to 1 and
>>>>> NOP when writing to 0. That is confusing and un-necessary.
>>>>>
>>>>
>>>
>>> Hi Valentin, Thanks for taking a look at this patch.
>>>
>>>> But why would you write to it in the first place? Or do you mean to use
>>>> this as an indicator for userspace that EAS is supported?
>>>>
>>>
>>> Since this sysctl is present and its value being 1, it gives the
>>> impression to the user that EAS is supported when it is not.
>>> So its an attempt to correct that part.
>>>
>>
>> Ah, I see. Then how about just making the sysctl return 0 when EAS isn't
>> supported? And on top of it, prevent all writes when EAS isn't supported
>> (perf domains cannot be built, so there would be no point in forcing a
>> rebuild that will do nothing).
>
> I think the issue comes from the fact there is no variable representing
> whether EAS is supported or not. sched_energy_enabled()/sched_energy_present
> tells whether EAS is actively running on the system instead.
>
> So on a system with EAS running, I think what would happen is:
> # Disable EAS and set sched_energy_present=0
> echo 0 > /proc/sys/kernel/sched_energy_aware
>
> # sched_energy_present==0, so we get -EOPNOTSUPP
> echo 1 > /proc/sys/kernel/sched_energy_aware
>
Ah, quite so, I didn't think this through!
next prev parent reply other threads:[~2023-09-18 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:48 Shrikanth Hegde
2023-09-14 0:01 ` kernel test robot
2023-09-14 17:59 ` Shrikanth Hegde
2023-09-14 16:21 ` Valentin Schneider
2023-09-14 17:56 ` Shrikanth Hegde
2023-09-15 12:00 ` Valentin Schneider
2023-09-15 13:35 ` Pierre Gondois
2023-09-18 12:21 ` Valentin Schneider [this message]
2023-09-15 18:10 ` Shrikanth Hegde
2023-09-18 12:22 ` Valentin Schneider
2023-09-18 17:39 ` Shrikanth Hegde
2023-09-22 14:44 ` Pierre Gondois
2023-09-22 21:02 ` Shrikanth Hegde
2023-09-20 17:47 ` Shrikanth Hegde
2023-09-18 12:00 ` Pierre Gondois
2023-09-18 12:57 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhsmhbkdzvfiq.mognet@vschneid.remote.csb \
--to=vschneid@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=quentin.perret@arm.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=sshegde@linux.vnet.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®