* [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push_task
@ 2023-05-10 23:54 Li zeming
2023-06-12 9:21 ` Valentin Schneider
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-05-10 23:54 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, vschneid
Cc: linux-kernel, Li zeming
push_task is assigned first, so it does not need to initialize the
assignment.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 662c565745fd..55e480d5174a 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2073,7 +2073,7 @@ static int push_rt_task(struct rq *rq, bool pull)
}
if (is_migration_disabled(next_task)) {
- struct task_struct *push_task = NULL;
+ struct task_struct *push_task;
int cpu;
if (!pull || rq->push_busy)
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push_task
2023-05-10 23:54 [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push_task Li zeming
@ 2023-06-12 9:21 ` Valentin Schneider
0 siblings, 0 replies; 2+ messages in thread
From: Valentin Schneider @ 2023-06-12 9:21 UTC (permalink / raw)
To: Li zeming, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot
Cc: linux-kernel, Li zeming
On 11/05/23 07:54, Li zeming wrote:
> push_task is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Subject would be clearer as "Remove unnecessary initialization", but
regardless:
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/sched/rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 662c565745fd..55e480d5174a 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -2073,7 +2073,7 @@ static int push_rt_task(struct rq *rq, bool pull)
> }
>
> if (is_migration_disabled(next_task)) {
> - struct task_struct *push_task = NULL;
> + struct task_struct *push_task;
> int cpu;
>
> if (!pull || rq->push_busy)
> --
> 2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-12 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-10 23:54 [PATCH] sched: rt: Remove unnecessary ‘NULL’ values from push_task Li zeming
2023-06-12 9:21 ` Valentin Schneider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®