* [PATCH] scsi: qla2xxx: Remove redundant assignment to rval
@ 2021-05-10 10:40 Jiapeng Chong
2021-05-22 2:59 ` Martin K. Petersen
2021-05-26 4:07 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2021-05-10 10:40 UTC (permalink / raw)
To: njavali
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel, Jiapeng Chong
Variable rval is set to QLA_SUCCESS, but this value is never read as
it is overwritten later on, hence it is a redundant assignment and
can be removed.
Clean up the following clang-analyzer warning:
drivers/scsi/qla2xxx/qla_init.c:4359:2: warning: Value stored to 'rval'
is never read [clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/scsi/qla2xxx/qla_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 0de2505..eb82531 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -4356,8 +4356,6 @@ void qla_init_iocb_limit(scsi_qla_host_t *vha)
if (IS_QLAFX00(vha->hw))
return qlafx00_fw_ready(vha);
- rval = QLA_SUCCESS;
-
/* Time to wait for loop down */
if (IS_P3P_TYPE(ha))
min_wait = 30;
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove redundant assignment to rval
2021-05-10 10:40 [PATCH] scsi: qla2xxx: Remove redundant assignment to rval Jiapeng Chong
@ 2021-05-22 2:59 ` Martin K. Petersen
2021-05-26 4:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-05-22 2:59 UTC (permalink / raw)
To: Jiapeng Chong
Cc: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
Jiapeng,
> Variable rval is set to QLA_SUCCESS, but this value is never read as
> it is overwritten later on, hence it is a redundant assignment and
> can be removed.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove redundant assignment to rval
2021-05-10 10:40 [PATCH] scsi: qla2xxx: Remove redundant assignment to rval Jiapeng Chong
2021-05-22 2:59 ` Martin K. Petersen
@ 2021-05-26 4:07 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-05-26 4:07 UTC (permalink / raw)
To: Jiapeng Chong, njavali
Cc: Martin K . Petersen, jejb, GR-QLogic-Storage-Upstream,
linux-scsi, linux-kernel
On Mon, 10 May 2021 18:40:06 +0800, Jiapeng Chong wrote:
> Variable rval is set to QLA_SUCCESS, but this value is never read as
> it is overwritten later on, hence it is a redundant assignment and
> can be removed.
>
> Clean up the following clang-analyzer warning:
>
> drivers/scsi/qla2xxx/qla_init.c:4359:2: warning: Value stored to 'rval'
> is never read [clang-analyzer-deadcode.DeadStores].
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove redundant assignment to rval
https://git.kernel.org/mkp/scsi/c/cb9eb11fd572
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-26 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 10:40 [PATCH] scsi: qla2xxx: Remove redundant assignment to rval Jiapeng Chong
2021-05-22 2:59 ` Martin K. Petersen
2021-05-26 4:07 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®