mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support
@ 2025-11-06 14:21 Thomas Richard (TI.com)
  2025-11-08 17:58 ` Martin K. Petersen
  2025-11-13  2:46 ` Martin K. Petersen
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Richard (TI.com) @ 2025-11-06 14:21 UTC (permalink / raw)
  To: James E.J. Bottomley, Martin K. Petersen
  Cc: Thomas Petazzoni, Gregory CLEMENT, Udit Kumar, Prasanth Mantena,
	Abhash Kumar, linux-scsi, linux-kernel, Thomas Richard (TI.com)

Restore the ctrl register to resume the TI UFS wrapper.

Signed-off-by: Thomas Richard (TI.com) <thomas.richard@bootlin.com>
---
 drivers/ufs/host/ti-j721e-ufs.c | 37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/drivers/ufs/host/ti-j721e-ufs.c b/drivers/ufs/host/ti-j721e-ufs.c
index 21214e5d5896..43781593b5c1 100644
--- a/drivers/ufs/host/ti-j721e-ufs.c
+++ b/drivers/ufs/host/ti-j721e-ufs.c
@@ -15,18 +15,26 @@
 #define TI_UFS_SS_RST_N_PCS	BIT(0)
 #define TI_UFS_SS_CLK_26MHZ	BIT(4)
 
+struct ti_j721e_ufs {
+	void __iomem *regbase;
+	u32 reg;
+};
+
 static int ti_j721e_ufs_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
+	struct ti_j721e_ufs *ufs;
 	unsigned long clk_rate;
-	void __iomem *regbase;
 	struct clk *clk;
-	u32 reg = 0;
 	int ret;
 
-	regbase = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(regbase))
-		return PTR_ERR(regbase);
+	ufs = devm_kzalloc(dev, sizeof(*ufs), GFP_KERNEL);
+	if (!ufs)
+		return -ENOMEM;
+
+	ufs->regbase = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(ufs->regbase))
+		return PTR_ERR(ufs->regbase);
 
 	pm_runtime_enable(dev);
 	ret = pm_runtime_resume_and_get(dev);
@@ -42,12 +50,14 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev)
 	}
 	clk_rate = clk_get_rate(clk);
 	if (clk_rate == 26000000)
-		reg |= TI_UFS_SS_CLK_26MHZ;
+		ufs->reg |= TI_UFS_SS_CLK_26MHZ;
 	devm_clk_put(dev, clk);
 
 	/*  Take UFS slave device out of reset */
-	reg |= TI_UFS_SS_RST_N_PCS;
-	writel(reg, regbase + TI_UFS_SS_CTRL);
+	ufs->reg |= TI_UFS_SS_RST_N_PCS;
+	writel(ufs->reg, ufs->regbase + TI_UFS_SS_CTRL);
+
+	dev_set_drvdata(dev, ufs);
 
 	ret = of_platform_populate(pdev->dev.of_node, NULL, NULL,
 				   dev);
@@ -72,6 +82,16 @@ static void ti_j721e_ufs_remove(struct platform_device *pdev)
 	pm_runtime_disable(&pdev->dev);
 }
 
+static int ti_j721e_ufs_resume(struct device *dev)
+{
+	struct ti_j721e_ufs *ufs = dev_get_drvdata(dev);
+
+	writel(ufs->reg, ufs->regbase + TI_UFS_SS_CTRL);
+	return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(ti_j721e_ufs_pm_ops, NULL, ti_j721e_ufs_resume);
+
 static const struct of_device_id ti_j721e_ufs_of_match[] = {
 	{
 		.compatible = "ti,j721e-ufs",
@@ -87,6 +107,7 @@ static struct platform_driver ti_j721e_ufs_driver = {
 	.driver	= {
 		.name   = "ti-j721e-ufs",
 		.of_match_table = ti_j721e_ufs_of_match,
+		.pm = pm_sleep_ptr(&ti_j721e_ufs_pm_ops),
 	},
 };
 module_platform_driver(ti_j721e_ufs_driver);

---
base-commit: 709f6117c3b05c87ef975725074062920d1bbfdc
change-id: 20251106-scsi-ufs-ti-j721e-suspend-resume-support-cbea00948a57

Best regards,
-- 
Thomas Richard (TI.com) <thomas.richard@bootlin.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support
  2025-11-06 14:21 [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support Thomas Richard (TI.com)
@ 2025-11-08 17:58 ` Martin K. Petersen
  2025-11-13  2:46 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-11-08 17:58 UTC (permalink / raw)
  To: Thomas Richard (TI.com)
  Cc: James E.J. Bottomley, Martin K. Petersen, Thomas Petazzoni,
	Gregory CLEMENT, Udit Kumar, Prasanth Mantena, Abhash Kumar,
	linux-scsi, linux-kernel


Thomas,

> Restore the ctrl register to resume the TI UFS wrapper.

Applied to 6.19/scsi-staging, thanks!

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support
  2025-11-06 14:21 [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support Thomas Richard (TI.com)
  2025-11-08 17:58 ` Martin K. Petersen
@ 2025-11-13  2:46 ` Martin K. Petersen
  1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-11-13  2:46 UTC (permalink / raw)
  To: James E.J. Bottomley, Thomas Richard (TI.com)
  Cc: Martin K . Petersen, Thomas Petazzoni, Gregory CLEMENT,
	Udit Kumar, Prasanth Mantena, Abhash Kumar, linux-scsi,
	linux-kernel

On Thu, 06 Nov 2025 15:21:54 +0100, Thomas Richard (TI.com) wrote:

> Restore the ctrl register to resume the TI UFS wrapper.
> 
> 

Applied to 6.19/scsi-queue, thanks!

[1/1] scsi: ufs: ti-j721e: Add suspend-resume support
      https://git.kernel.org/mkp/scsi/c/02880c083c13

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-13  2:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-06 14:21 [PATCH] scsi: ufs: ti-j721e: Add suspend-resume support Thomas Richard (TI.com)
2025-11-08 17:58 ` Martin K. Petersen
2025-11-13  2:46 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®