* [PATCH] scsi: qla4xxx: use time conversion macros
@ 2025-11-17 20:09 Shi Hao
2025-11-29 21:40 ` Martin K. Petersen
2025-12-09 3:21 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Shi Hao @ 2025-11-17 20:09 UTC (permalink / raw)
To: njavali
Cc: mrangankar, GR-QLogic-Storage-Upstream, James.Bottomley,
martin.petersen, linux-scsi, linux-kernel, i.shihao.999
Replace the raw use of 500 value in schedule_timeout()
function with msecs_to_jiffies() to ensure intended value
across different kernel configurations regardless of HZ
value.
Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
---
drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
index da2fc66ffedd..b0a62aaa1cca 100644
--- a/drivers/scsi/qla4xxx/ql4_nx.c
+++ b/drivers/scsi/qla4xxx/ql4_nx.c
@@ -1552,7 +1552,7 @@ static int qla4_82xx_cmdpeg_ready(struct scsi_qla_host *ha, int pegtune_val)
(val == PHAN_INITIALIZE_ACK))
return 0;
set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(500);
+ schedule_timeout(msecs_to_jiffies(500));
} while (--retries);
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla4xxx: use time conversion macros
2025-11-17 20:09 [PATCH] scsi: qla4xxx: use time conversion macros Shi Hao
@ 2025-11-29 21:40 ` Martin K. Petersen
2025-12-09 3:21 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-11-29 21:40 UTC (permalink / raw)
To: Shi Hao
Cc: njavali, mrangankar, GR-QLogic-Storage-Upstream, James.Bottomley,
martin.petersen, linux-scsi, linux-kernel
Shi,
> Replace the raw use of 500 value in schedule_timeout() function with
> msecs_to_jiffies() to ensure intended value across different kernel
> configurations regardless of HZ value.
Applied to 6.19/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla4xxx: use time conversion macros
2025-11-17 20:09 [PATCH] scsi: qla4xxx: use time conversion macros Shi Hao
2025-11-29 21:40 ` Martin K. Petersen
@ 2025-12-09 3:21 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-12-09 3:21 UTC (permalink / raw)
To: njavali, Shi Hao
Cc: Martin K . Petersen, mrangankar, GR-QLogic-Storage-Upstream,
James.Bottomley, linux-scsi, linux-kernel
On Tue, 18 Nov 2025 01:39:49 +0530, Shi Hao wrote:
> Replace the raw use of 500 value in schedule_timeout()
> function with msecs_to_jiffies() to ensure intended value
> across different kernel configurations regardless of HZ
> value.
>
>
Applied to 6.19/scsi-queue, thanks!
[1/1] scsi: qla4xxx: use time conversion macros
https://git.kernel.org/mkp/scsi/c/9086cac895c3
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-09 3:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-17 20:09 [PATCH] scsi: qla4xxx: use time conversion macros Shi Hao
2025-11-29 21:40 ` Martin K. Petersen
2025-12-09 3:21 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®