* [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value
@ 2025-06-27 11:41 Thomas Fourier
2025-07-14 17:38 ` Martin K. Petersen
2025-07-22 3:47 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Fourier @ 2025-06-27 11:41 UTC (permalink / raw)
Cc: Thomas Fourier, James Smart, Ram Vegesna, James E.J. Bottomley,
Martin K. Petersen, Bart Van Assche, Peter Wang, Hannes Reinecke,
Daniel Wagner, linux-scsi, target-devel, linux-kernel
The dma_unmap_sg() functions should be called with the same nents as the
dma_map_sg(), not the value the map function returned.
Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
---
drivers/scsi/elx/efct/efct_lio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/elx/efct/efct_lio.c b/drivers/scsi/elx/efct/efct_lio.c
index 9ac69356b13e..bd3d489e56ae 100644
--- a/drivers/scsi/elx/efct/efct_lio.c
+++ b/drivers/scsi/elx/efct/efct_lio.c
@@ -382,7 +382,7 @@ efct_lio_sg_unmap(struct efct_io *io)
return;
dma_unmap_sg(&io->efct->pci->dev, cmd->t_data_sg,
- ocp->seg_map_cnt, cmd->data_direction);
+ cmd->t_data_nents, cmd->data_direction);
ocp->seg_map_cnt = 0;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value
2025-06-27 11:41 [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value Thomas Fourier
@ 2025-07-14 17:38 ` Martin K. Petersen
2025-07-22 3:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-07-14 17:38 UTC (permalink / raw)
To: Thomas Fourier
Cc: James Smart, Ram Vegesna, James E.J. Bottomley,
Martin K. Petersen, Bart Van Assche, Peter Wang, Hannes Reinecke,
Daniel Wagner, linux-scsi, target-devel, linux-kernel
Thomas,
> The dma_unmap_sg() functions should be called with the same nents as the
> dma_map_sg(), not the value the map function returned.
Applied to 6.17/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value
2025-06-27 11:41 [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value Thomas Fourier
2025-07-14 17:38 ` Martin K. Petersen
@ 2025-07-22 3:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-07-22 3:47 UTC (permalink / raw)
To: Thomas Fourier
Cc: Martin K . Petersen, James Smart, Ram Vegesna,
James E.J. Bottomley, Bart Van Assche, Peter Wang,
Hannes Reinecke, Daniel Wagner, linux-scsi, target-devel,
linux-kernel
On Fri, 27 Jun 2025 13:41:13 +0200, Thomas Fourier wrote:
> The dma_unmap_sg() functions should be called with the same nents as the
> dma_map_sg(), not the value the map function returned.
>
>
Applied to 6.17/scsi-queue, thanks!
[1/1] scsi: elx: efct: Fix dma_unmap_sg() nents value
https://git.kernel.org/mkp/scsi/c/3a988d0b65d7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-22 3:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-27 11:41 [PATCH] scsi: elx: efct: Fix dma_unmap_sg() nents value Thomas Fourier
2025-07-14 17:38 ` Martin K. Petersen
2025-07-22 3:47 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®