From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Calvin Owens <calvinowens@fb.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<MPT-FusionLinux.pdl@broadcom.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH 3/3] mpt3sas: Fix warnings exposed by W=1
Date: Mon, 08 Aug 2016 21:16:10 -0400 [thread overview]
Message-ID: <yq160ravj1h.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com> (Calvin Owens's message of "Thu, 28 Jul 2016 21:38:22 -0700")
>>>>> "Calvin" == Calvin Owens <calvinowens@fb.com> writes:
Calvin> Trivial non-functional changes for a couple annoying things: 1)
Calvin> Functions local to files are not declared static, which is
Calvin> frustrating when reading the code because it's non-obvious at
Calvin> first glance what's actually called from other files.
Calvin> 2) Set-but-unused variables abound, presumably to mask
Calvin> -Wunused-result errors in the past. None of these are flagged
Calvin> today though (with one exception noted below), so remove them.
Calvin> Fixing (2) exposed the fact that we improperly ignore the return
Calvin> value of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing
Calvin> the calling code to deal with the potential error is
Calvin> non-trivial, so for now just WARN().
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-08-09 1:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 4:38 [PATCH 1/3] mpt3sas: Eliminate conditional locking in mpt3sas_scsih_issue_tm() Calvin Owens
2016-07-29 4:38 ` [PATCH 2/3] mpt3sas: Eliminate dead sleep_flag code Calvin Owens
2016-08-05 4:29 ` Chaitra Basappa
2016-08-09 1:14 ` Martin K. Petersen
2016-07-29 4:38 ` [PATCH 3/3] mpt3sas: Fix warnings exposed by W=1 Calvin Owens
2016-08-05 4:29 ` Chaitra Basappa
2016-08-09 1:16 ` Martin K. Petersen [this message]
2016-08-05 4:29 ` [PATCH 1/3] mpt3sas: Eliminate conditional locking in mpt3sas_scsih_issue_tm() Chaitra Basappa
2016-08-09 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq160ravj1h.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=calvinowens@fb.com \
--cc=chaitra.basappa@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome