* [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p
@ 2026-07-28 5:11 Shawn Guo
2026-09-09 10:24 ` Manivannan Sadhasivam
2026-09-18 1:51 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Shawn Guo @ 2026-07-28 5:11 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Manivannan Sadhasivam, James E . J . Bottomley, linux-arm-msm,
linux-scsi, linux-kernel, Shawn Guo
The sa8255p vops (fw-managed variant) was missing the MCQ hooks, causing
the driver to silently fall back to SDB mode even when MCQ resource is
available. Wire up the same MCQ ops used by the standard qcom vops,
so that MCQ mode works on sa8255p.
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
drivers/ufs/host/ufs-qcom.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 0500320545c4..d2acbbe647cb 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -2950,6 +2950,11 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_sa8255p_vops = {
.resume = ufs_qcom_fw_managed_resume,
.dbg_register_dump = ufs_qcom_dump_dbg_regs,
.device_reset = ufs_qcom_fw_managed_device_reset,
+ .mcq_config_resource = ufs_qcom_mcq_config_resource,
+ .get_hba_mac = ufs_qcom_get_hba_mac,
+ .op_runtime_config = ufs_qcom_op_runtime_config,
+ .get_outstanding_cqs = ufs_qcom_get_outstanding_cqs,
+ .config_esi = ufs_qcom_config_esi,
};
/**
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p
2026-07-28 5:11 [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p Shawn Guo
@ 2026-09-09 10:24 ` Manivannan Sadhasivam
2026-09-18 1:51 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2026-09-09 10:24 UTC (permalink / raw)
To: Shawn Guo
Cc: Martin K . Petersen, James E . J . Bottomley, linux-arm-msm,
linux-scsi, linux-kernel
On Tue, Jul 28, 2026 at 01:11:04PM +0800, Shawn Guo wrote:
> The sa8255p vops (fw-managed variant) was missing the MCQ hooks, causing
> the driver to silently fall back to SDB mode even when MCQ resource is
> available. Wire up the same MCQ ops used by the standard qcom vops,
> so that MCQ mode works on sa8255p.
>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p
2026-07-28 5:11 [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p Shawn Guo
2026-09-09 10:24 ` Manivannan Sadhasivam
@ 2026-09-18 1:51 ` Shawn Guo
2026-09-26 2:38 ` Martin K. Petersen (Oracle)
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2026-09-18 1:51 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Manivannan Sadhasivam, James E . J . Bottomley, linux-arm-msm,
linux-scsi, linux-kernel
On Tue, Jul 28, 2026 at 01:11:04PM +0800, Shawn Guo wrote:
> The sa8255p vops (fw-managed variant) was missing the MCQ hooks, causing
> the driver to silently fall back to SDB mode even when MCQ resource is
> available. Wire up the same MCQ ops used by the standard qcom vops,
> so that MCQ mode works on sa8255p.
>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Hi Martin,
Did you get a chance to look at this change? It still applies to both
mainline and linux-next.
Shawn
> ---
> drivers/ufs/host/ufs-qcom.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 0500320545c4..d2acbbe647cb 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -2950,6 +2950,11 @@ static const struct ufs_hba_variant_ops ufs_hba_qcom_sa8255p_vops = {
> .resume = ufs_qcom_fw_managed_resume,
> .dbg_register_dump = ufs_qcom_dump_dbg_regs,
> .device_reset = ufs_qcom_fw_managed_device_reset,
> + .mcq_config_resource = ufs_qcom_mcq_config_resource,
> + .get_hba_mac = ufs_qcom_get_hba_mac,
> + .op_runtime_config = ufs_qcom_op_runtime_config,
> + .get_outstanding_cqs = ufs_qcom_get_outstanding_cqs,
> + .config_esi = ufs_qcom_config_esi,
> };
>
> /**
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p
2026-09-18 1:51 ` Shawn Guo
@ 2026-09-26 2:38 ` Martin K. Petersen (Oracle)
0 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-09-26 2:38 UTC (permalink / raw)
To: Shawn Guo
Cc: Martin K . Petersen, Manivannan Sadhasivam,
James E . J . Bottomley, linux-arm-msm, linux-scsi, linux-kernel
Shawn,
>> The sa8255p vops (fw-managed variant) was missing the MCQ hooks, causing
>> the driver to silently fall back to SDB mode even when MCQ resource is
>> available. Wire up the same MCQ ops used by the standard qcom vops,
>> so that MCQ mode works on sa8255p.
Applied to 7.4/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-26 2:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-28 5:11 [PATCH] ufs: host: qcom: Enable MCQ support for sa8255p Shawn Guo
2026-09-09 10:24 ` Manivannan Sadhasivam
2026-09-18 1:51 ` Shawn Guo
2026-09-26 2:38 ` Martin K. Petersen (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®