* [PATCH] scsi: pm8001: Use int instead of u32 to store error codes
@ 2025-08-26 9:32 Qianfeng Rong
2025-08-31 1:38 ` Martin K. Petersen
2025-09-10 3:04 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Qianfeng Rong @ 2025-08-26 9:32 UTC (permalink / raw)
To: Jack Wang, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Cc: Qianfeng Rong
Use int instead of u32 for 'ret' variable to store negative error codes
returned by PM8001_CHIP_DISP->set_nvmd_req().
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/scsi/pm8001/pm8001_ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 7618f9cc9986..6e76b1cae220 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -680,7 +680,7 @@ static int pm8001_set_nvmd(struct pm8001_hba_info *pm8001_ha)
struct pm8001_ioctl_payload *payload;
DECLARE_COMPLETION_ONSTACK(completion);
u8 *ioctlbuffer;
- u32 ret;
+ int ret;
u32 length = 1024 * 5 + sizeof(*payload) - 1;
if (pm8001_ha->fw_image->size > 4096) {
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pm8001: Use int instead of u32 to store error codes
2025-08-26 9:32 [PATCH] scsi: pm8001: Use int instead of u32 to store error codes Qianfeng Rong
@ 2025-08-31 1:38 ` Martin K. Petersen
2025-09-10 3:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-08-31 1:38 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Jack Wang, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
Qianfeng,
> Use int instead of u32 for 'ret' variable to store negative error codes
> returned by PM8001_CHIP_DISP->set_nvmd_req().
Applied to 6.18/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pm8001: Use int instead of u32 to store error codes
2025-08-26 9:32 [PATCH] scsi: pm8001: Use int instead of u32 to store error codes Qianfeng Rong
2025-08-31 1:38 ` Martin K. Petersen
@ 2025-09-10 3:04 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-09-10 3:04 UTC (permalink / raw)
To: Jack Wang, James E.J. Bottomley, linux-scsi, linux-kernel, Qianfeng Rong
Cc: Martin K . Petersen
On Tue, 26 Aug 2025 17:32:42 +0800, Qianfeng Rong wrote:
> Use int instead of u32 for 'ret' variable to store negative error codes
> returned by PM8001_CHIP_DISP->set_nvmd_req().
>
>
Applied to 6.18/scsi-queue, thanks!
[1/1] scsi: pm8001: Use int instead of u32 to store error codes
https://git.kernel.org/mkp/scsi/c/bee3554d1a4e
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-10 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-26 9:32 [PATCH] scsi: pm8001: Use int instead of u32 to store error codes Qianfeng Rong
2025-08-31 1:38 ` Martin K. Petersen
2025-09-10 3:04 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®