* [PATCH -next] scsi: pm8001: Remove unused declarations
@ 2023-08-18 12:47 Yue Haibing
2023-08-21 19:51 ` Bart Van Assche
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Yue Haibing @ 2023-08-18 12:47 UTC (permalink / raw)
To: jinpu.wang, jejb, martin.petersen, john.garry
Cc: linux-scsi, linux-kernel, yuehaibing
Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
removed these implementations but not the declarations.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
drivers/scsi/pm8001/pm8001_sas.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
index 953572fc0d9e..2fadd353f1c1 100644
--- a/drivers/scsi/pm8001/pm8001_sas.h
+++ b/drivers/scsi/pm8001/pm8001_sas.h
@@ -702,8 +702,6 @@ int pm8001_mpi_fw_flash_update_resp(struct pm8001_hba_info *pm8001_ha,
void *piomb);
int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha, void *piomb);
int pm8001_mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb);
-struct sas_task *pm8001_alloc_task(void);
-void pm8001_free_task(struct sas_task *task);
void pm8001_tag_free(struct pm8001_hba_info *pm8001_ha, u32 tag);
struct pm8001_device *pm8001_find_dev(struct pm8001_hba_info *pm8001_ha,
u32 device_id);
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] scsi: pm8001: Remove unused declarations
2023-08-18 12:47 [PATCH -next] scsi: pm8001: Remove unused declarations Yue Haibing
@ 2023-08-21 19:51 ` Bart Van Assche
2023-08-21 19:55 ` Jinpu Wang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2023-08-21 19:51 UTC (permalink / raw)
To: Yue Haibing, jinpu.wang, jejb, martin.petersen, john.garry
Cc: linux-scsi, linux-kernel
On 8/18/23 05:47, Yue Haibing wrote:
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] scsi: pm8001: Remove unused declarations
2023-08-18 12:47 [PATCH -next] scsi: pm8001: Remove unused declarations Yue Haibing
2023-08-21 19:51 ` Bart Van Assche
@ 2023-08-21 19:55 ` Jinpu Wang
2023-08-21 21:06 ` Martin K. Petersen
2023-08-25 1:13 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Jinpu Wang @ 2023-08-21 19:55 UTC (permalink / raw)
To: Yue Haibing
Cc: jinpu.wang, jejb, martin.petersen, john.garry, linux-scsi, linux-kernel
On Fri, Aug 18, 2023 at 2:47 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/scsi/pm8001/pm8001_sas.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
> index 953572fc0d9e..2fadd353f1c1 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.h
> +++ b/drivers/scsi/pm8001/pm8001_sas.h
> @@ -702,8 +702,6 @@ int pm8001_mpi_fw_flash_update_resp(struct pm8001_hba_info *pm8001_ha,
> void *piomb);
> int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha, void *piomb);
> int pm8001_mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb);
> -struct sas_task *pm8001_alloc_task(void);
> -void pm8001_free_task(struct sas_task *task);
> void pm8001_tag_free(struct pm8001_hba_info *pm8001_ha, u32 tag);
> struct pm8001_device *pm8001_find_dev(struct pm8001_hba_info *pm8001_ha,
> u32 device_id);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] scsi: pm8001: Remove unused declarations
2023-08-18 12:47 [PATCH -next] scsi: pm8001: Remove unused declarations Yue Haibing
2023-08-21 19:51 ` Bart Van Assche
2023-08-21 19:55 ` Jinpu Wang
@ 2023-08-21 21:06 ` Martin K. Petersen
2023-08-25 1:13 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-08-21 21:06 UTC (permalink / raw)
To: Yue Haibing
Cc: jinpu.wang, jejb, martin.petersen, john.garry, linux-scsi, linux-kernel
Yue,
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] scsi: pm8001: Remove unused declarations
2023-08-18 12:47 [PATCH -next] scsi: pm8001: Remove unused declarations Yue Haibing
` (2 preceding siblings ...)
2023-08-21 21:06 ` Martin K. Petersen
@ 2023-08-25 1:13 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2023-08-25 1:13 UTC (permalink / raw)
To: jinpu.wang, jejb, john.garry, Yue Haibing
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Fri, 18 Aug 2023 20:47:00 +0800, Yue Haibing wrote:
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
>
>
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: pm8001: Remove unused declarations
https://git.kernel.org/mkp/scsi/c/04aff456af18
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-25 1:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 12:47 [PATCH -next] scsi: pm8001: Remove unused declarations Yue Haibing
2023-08-21 19:51 ` Bart Van Assche
2023-08-21 19:55 ` Jinpu Wang
2023-08-21 21:06 ` Martin K. Petersen
2023-08-25 1:13 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®