* [PATCH] scsi: remove redundant initialization of variable ret
@ 2020-09-18 9:07 Jing Xiangfeng
2020-09-19 7:36 ` Finn Thain
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jing Xiangfeng @ 2020-09-18 9:07 UTC (permalink / raw)
To: fthain, schmitzmic, linux, jejb, martin.petersen
Cc: linux-scsi, linux-arm-kernel, linux-kernel, jingxiangfeng
The variable ret is being initialized with '-ENOMEM' that is
meaningless. So remove it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/scsi/arm/oak.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/arm/oak.c b/drivers/scsi/arm/oak.c
index 7c9d361e91a9..78f33d57c3e8 100644
--- a/drivers/scsi/arm/oak.c
+++ b/drivers/scsi/arm/oak.c
@@ -120,7 +120,7 @@ static struct scsi_host_template oakscsi_template = {
static int oakscsi_probe(struct expansion_card *ec, const struct ecard_id *id)
{
struct Scsi_Host *host;
- int ret = -ENOMEM;
+ int ret;
ret = ecard_request_resources(ec);
if (ret)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: remove redundant initialization of variable ret
2020-09-18 9:07 [PATCH] scsi: remove redundant initialization of variable ret Jing Xiangfeng
@ 2020-09-19 7:36 ` Finn Thain
2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Finn Thain @ 2020-09-19 7:36 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: schmitzmic, linux, jejb, martin.petersen, linux-scsi,
linux-arm-kernel, linux-kernel
On Fri, 18 Sep 2020, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is
> meaningless. So remove it.
>
Acked-by: Finn Thain <fthain@telegraphics.com.au>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: remove redundant initialization of variable ret
2020-09-18 9:07 [PATCH] scsi: remove redundant initialization of variable ret Jing Xiangfeng
2020-09-19 7:36 ` Finn Thain
@ 2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-23 0:29 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: fthain, schmitzmic, linux, jejb, martin.petersen, linux-scsi,
linux-arm-kernel, linux-kernel
Jing,
> The variable ret is being initialized with '-ENOMEM' that is
> meaningless. So remove it.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: remove redundant initialization of variable ret
2020-09-18 9:07 [PATCH] scsi: remove redundant initialization of variable ret Jing Xiangfeng
2020-09-19 7:36 ` Finn Thain
2020-09-23 0:29 ` Martin K. Petersen
@ 2020-09-30 3:34 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-09-30 3:34 UTC (permalink / raw)
To: Jing Xiangfeng, fthain, linux, schmitzmic, jejb
Cc: Martin K . Petersen, linux-scsi, linux-arm-kernel, linux-kernel
On Fri, 18 Sep 2020 17:07:47 +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with '-ENOMEM' that is
> meaningless. So remove it.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: oak: Remove redundant initialization of variable ret
https://git.kernel.org/mkp/scsi/c/713a846884ce
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-30 3:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 9:07 [PATCH] scsi: remove redundant initialization of variable ret Jing Xiangfeng
2020-09-19 7:36 ` Finn Thain
2020-09-23 0:29 ` Martin K. Petersen
2020-09-30 3:34 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®