* [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup()
@ 2023-08-14 14:03 Tony Battersby
2023-08-14 17:15 ` Bart Van Assche
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tony Battersby @ 2023-08-14 14:03 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen; +Cc: linux-scsi, linux-kernel
Change scsi_host_lookup() hostnum argument type from unsigned
short to unsigned int to match the type used everywhere else.
Fixes: 6d49f63b415c ("[SCSI] Make host_no an unsigned int")
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
drivers/scsi/hosts.c | 4 ++--
include/scsi/scsi_host.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 198edf03f929..d7f51b84f3c7 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -537,7 +537,7 @@ EXPORT_SYMBOL(scsi_host_alloc);
static int __scsi_host_match(struct device *dev, const void *data)
{
struct Scsi_Host *p;
- const unsigned short *hostnum = data;
+ const unsigned int *hostnum = data;
p = class_to_shost(dev);
return p->host_no == *hostnum;
@@ -554,7 +554,7 @@ static int __scsi_host_match(struct device *dev, const void *data)
* that scsi_host_get() took. The put_device() below dropped
* the reference from class_find_device().
**/
-struct Scsi_Host *scsi_host_lookup(unsigned short hostnum)
+struct Scsi_Host *scsi_host_lookup(unsigned int hostnum)
{
struct device *cdev;
struct Scsi_Host *shost = NULL;
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 70b7475dcf56..a2b8d30c4c80 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -769,7 +769,7 @@ extern void scsi_remove_host(struct Scsi_Host *);
extern struct Scsi_Host *scsi_host_get(struct Scsi_Host *);
extern int scsi_host_busy(struct Scsi_Host *shost);
extern void scsi_host_put(struct Scsi_Host *t);
-extern struct Scsi_Host *scsi_host_lookup(unsigned short);
+extern struct Scsi_Host *scsi_host_lookup(unsigned int hostnum);
extern const char *scsi_host_state_name(enum scsi_host_state);
extern void scsi_host_complete_all_commands(struct Scsi_Host *shost,
enum scsi_host_status status);
base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup()
2023-08-14 14:03 [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup() Tony Battersby
@ 2023-08-14 17:15 ` Bart Van Assche
2023-08-21 20:42 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2023-08-14 17:15 UTC (permalink / raw)
To: Tony Battersby, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 8/14/23 07:03, Tony Battersby wrote:
> Change scsi_host_lookup() hostnum argument type from unsigned
> short to unsigned int to match the type used everywhere else.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup()
2023-08-14 14:03 [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup() Tony Battersby
2023-08-14 17:15 ` Bart Van Assche
@ 2023-08-21 20:42 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-08-21 20:42 UTC (permalink / raw)
To: Tony Battersby
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Tony,
> Change scsi_host_lookup() hostnum argument type from unsigned short to
> unsigned int to match the type used everywhere else.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup()
2023-08-14 14:03 [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup() Tony Battersby
2023-08-14 17:15 ` Bart Van Assche
2023-08-21 20:42 ` Martin K. Petersen
@ 2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-08-25 1:12 UTC (permalink / raw)
To: James E.J. Bottomley, Tony Battersby
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Mon, 14 Aug 2023 10:03:25 -0400, Tony Battersby wrote:
> Change scsi_host_lookup() hostnum argument type from unsigned
> short to unsigned int to match the type used everywhere else.
>
>
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: core: Use 32-bit hostnum in scsi_host_lookup()
https://git.kernel.org/mkp/scsi/c/62ec2092095b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-25 1:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-14 14:03 [PATCH] scsi: core: Use 32-bit hostnum in scsi_host_lookup() Tony Battersby
2023-08-14 17:15 ` Bart Van Assche
2023-08-21 20:42 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®