* [PATCH V3] scsi: ufs: ufs-qcom: Change UFS devfreq timer to delayed
@ 2023-07-20 9:34 Nitin Rawat
2023-07-23 20:32 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Nitin Rawat @ 2023-07-20 9:34 UTC (permalink / raw)
To: mani, quic_cang, stanley.chu, bvanassche, quic_asutoshd,
avri.altman, martin.petersen, beanhuo, konrad.dybcio
Cc: linux-scsi, linux-kernel, agross, andersson, jejb, linux-arm-msm,
quic_ziqichen, Nitin Rawat
Devfreq uses the default DEVFREQ_TIMER_DEFERRABLE mode which uses
the deferred timer for scheduling the devfreq load monitor function.
This causes the load monitoring to be done only with non-idle CPUs
and not making use of the idle CPUs.
Hence, use the DEVFREQ_TIMER_DELAYED mode which uses the delayed
timer thereby making use of idle CPUs as well for load monitoring.
Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
---
changes from v2:
- Modified commit message as per mani's suggestion
- removed threshold change
Changes from v1:
- Realigned the commit text
drivers/ufs/host/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index df9161cb9825..07e5050dae77 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1619,6 +1619,7 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
struct devfreq_simple_ondemand_data *d)
{
p->polling_ms = 60;
+ p->timer = DEVFREQ_TIMER_DELAYED;
d->upthreshold = 70;
d->downdifferential = 5;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V3] scsi: ufs: ufs-qcom: Change UFS devfreq timer to delayed
2023-07-20 9:34 [PATCH V3] scsi: ufs: ufs-qcom: Change UFS devfreq timer to delayed Nitin Rawat
@ 2023-07-23 20:32 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2023-07-23 20:32 UTC (permalink / raw)
To: Nitin Rawat
Cc: mani, quic_cang, stanley.chu, bvanassche, quic_asutoshd,
avri.altman, martin.petersen, beanhuo, konrad.dybcio, linux-scsi,
linux-kernel, agross, andersson, jejb, linux-arm-msm,
quic_ziqichen
Nitin,
> Devfreq uses the default DEVFREQ_TIMER_DEFERRABLE mode which uses the
> deferred timer for scheduling the devfreq load monitor function. This
> causes the load monitoring to be done only with non-idle CPUs and not
> making use of the idle CPUs.
>
> Hence, use the DEVFREQ_TIMER_DELAYED mode which uses the delayed timer
> thereby making use of idle CPUs as well for load monitoring.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-23 20:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-20 9:34 [PATCH V3] scsi: ufs: ufs-qcom: Change UFS devfreq timer to delayed Nitin Rawat
2023-07-23 20:32 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®