* [PATCH] imm: check parport_claim
@ 2016-02-24 10:57 Sudip Mukherjee
2016-02-24 13:40 ` Matthew R. Ochs
2016-02-26 2:11 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-02-24 10:57 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: linux-kernel, linux-scsi, Sudip Mukherjee
parport_claim() can fail and we should be checking if we were able to
claim the port.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/scsi/imm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index f8b88fa..9164ce12 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -77,9 +77,10 @@ static void imm_wakeup(void *ref)
spin_lock_irqsave(&arbitration_lock, flags);
if (dev->wanted) {
- parport_claim(dev->dev);
- got_it(dev);
- dev->wanted = 0;
+ if (parport_claim(dev->dev) == 0) {
+ got_it(dev);
+ dev->wanted = 0;
+ }
}
spin_unlock_irqrestore(&arbitration_lock, flags);
}
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] imm: check parport_claim
2016-02-24 10:57 [PATCH] imm: check parport_claim Sudip Mukherjee
@ 2016-02-24 13:40 ` Matthew R. Ochs
2016-02-26 2:11 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Matthew R. Ochs @ 2016-02-24 13:40 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Martin K. Petersen, linux-kernel, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] imm: check parport_claim
2016-02-24 10:57 [PATCH] imm: check parport_claim Sudip Mukherjee
2016-02-24 13:40 ` Matthew R. Ochs
@ 2016-02-26 2:11 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-02-26 2:11 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Martin K. Petersen, linux-kernel, linux-scsi
>>>>> "Sudip" == Sudip Mukherjee <sudipm.mukherjee@gmail.com> writes:
Sudip> parport_claim() can fail and we should be checking if we were
Sudip> able to claim the port.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-26 2:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-24 10:57 [PATCH] imm: check parport_claim Sudip Mukherjee
2016-02-24 13:40 ` Matthew R. Ochs
2016-02-26 2:11 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®