[PATCH] scsi: libcxgbi: Remove an unused field in struct cxgbi_device

[PATCH] scsi: libcxgbi: Remove an unused field in struct cxgbi_device

[Christophe JAILLET]

Usage of .dev_ddp_cleanup() in libcxgbi was removed by commit 5999299f1ce9
("cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support") on 2016-07.

.csk_rx_pdu_ready() and debugfs_root have apparently never been used since
introduction by commit 9ba682f01e2f ("[SCSI] libcxgbi: common library for
cxgb3i and cxgb4i")

Remove the now unused function pointer from struct cxgbi_device.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
---
 drivers/scsi/cxgbi/libcxgbi.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/cxgbi/libcxgbi.h b/drivers/scsi/cxgbi/libcxgbi.h
index d92cf1dccc2f..0909b03e2497 100644
--- a/drivers/scsi/cxgbi/libcxgbi.h
+++ b/drivers/scsi/cxgbi/libcxgbi.h
@@ -485,7 +485,6 @@ struct cxgbi_device {
 	unsigned char nmtus;
 	unsigned char nports;
 	struct pci_dev *pdev;
-	struct dentry *debugfs_root;
 	struct iscsi_transport *itp;
 	struct module *owner;
 
@@ -499,7 +498,6 @@ struct cxgbi_device {
 	unsigned int rxq_idx_cntr;
 	struct cxgbi_ports_map pmap;
 
-	void (*dev_ddp_cleanup)(struct cxgbi_device *);
 	struct cxgbi_ppm* (*cdev2ppm)(struct cxgbi_device *);
 	int (*csk_ddp_set_map)(struct cxgbi_ppm *, struct cxgbi_sock *,
 			       struct cxgbi_task_tag_info *);
@@ -512,7 +510,6 @@ struct cxgbi_device {
 				   unsigned int, int);
 
 	void (*csk_release_offload_resources)(struct cxgbi_sock *);
-	int (*csk_rx_pdu_ready)(struct cxgbi_sock *, struct sk_buff *);
 	u32 (*csk_send_rx_credits)(struct cxgbi_sock *, u32);
 	int (*csk_push_tx_frames)(struct cxgbi_sock *, int);
 	void (*csk_send_abort_req)(struct cxgbi_sock *);
-- 
2.46.0

Re: [PATCH] scsi: libcxgbi: Remove an unused field in struct cxgbi_device

[Martin K. Petersen]

Christophe,

> Usage of .dev_ddp_cleanup() in libcxgbi was removed by commit
> 5999299f1ce9 ("cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support") on
> 2016-07.

Applied to 6.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: libcxgbi: Remove an unused field in struct cxgbi_device

[Martin K. Petersen]

On Sun, 01 Sep 2024 22:45:27 +0200, Christophe JAILLET wrote:

> Usage of .dev_ddp_cleanup() in libcxgbi was removed by commit 5999299f1ce9
> ("cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support") on 2016-07.
> 
> .csk_rx_pdu_ready() and debugfs_root have apparently never been used since
> introduction by commit 9ba682f01e2f ("[SCSI] libcxgbi: common library for
> cxgb3i and cxgb4i")
> 
> [...]

Applied to 6.12/scsi-queue, thanks!

[1/1] scsi: libcxgbi: Remove an unused field in struct cxgbi_device
      https://git.kernel.org/mkp/scsi/c/45fad027df61

-- 
Martin K. Petersen	Oracle Linux Engineering