* [PATCH -next] snic: simplify the return expression of svnic_cq_alloc
@ 2020-09-21 8:24 Liu Shixin
2020-10-08 2:36 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Liu Shixin @ 2020-09-21 8:24 UTC (permalink / raw)
To: Karan Tilak Kumar, Sesidhar Baddela, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel, Liu Shixin
Simplify the return expression.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/scsi/snic/vnic_cq.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/scsi/snic/vnic_cq.c b/drivers/scsi/snic/vnic_cq.c
index 4c8e64e4fba6..3455dd7e73f4 100644
--- a/drivers/scsi/snic/vnic_cq.c
+++ b/drivers/scsi/snic/vnic_cq.c
@@ -31,8 +31,6 @@ void svnic_cq_free(struct vnic_cq *cq)
int svnic_cq_alloc(struct vnic_dev *vdev, struct vnic_cq *cq,
unsigned int index, unsigned int desc_count, unsigned int desc_size)
{
- int err;
-
cq->index = index;
cq->vdev = vdev;
@@ -43,11 +41,7 @@ int svnic_cq_alloc(struct vnic_dev *vdev, struct vnic_cq *cq,
return -EINVAL;
}
- err = svnic_dev_alloc_desc_ring(vdev, &cq->ring, desc_count, desc_size);
- if (err)
- return err;
-
- return 0;
+ return svnic_dev_alloc_desc_ring(vdev, &cq->ring, desc_count, desc_size);
}
void svnic_cq_init(struct vnic_cq *cq, unsigned int flow_control_enable,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] snic: simplify the return expression of svnic_cq_alloc
2020-09-21 8:24 [PATCH -next] snic: simplify the return expression of svnic_cq_alloc Liu Shixin
@ 2020-10-08 2:36 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-08 2:36 UTC (permalink / raw)
To: Liu Shixin
Cc: Karan Tilak Kumar, Sesidhar Baddela, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Liu,
> Simplify the return expression.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] snic: simplify the return expression of svnic_cq_alloc
2020-09-21 8:24 [PATCH -next] snic: simplify the return expression of svnic_cq_alloc Liu Shixin
2020-10-08 2:36 ` Martin K. Petersen
@ 2020-10-13 22:42 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-13 22:42 UTC (permalink / raw)
To: Liu Shixin, James E.J. Bottomley, Sesidhar Baddela, Karan Tilak Kumar
Cc: Martin K . Petersen, linux-kernel, linux-scsi
On Mon, 21 Sep 2020 16:24:55 +0800, Liu Shixin wrote:
> Simplify the return expression.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: snic: Simplify the return expression of svnic_cq_alloc()
https://git.kernel.org/mkp/scsi/c/6afc12fa6e50
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-13 22:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 8:24 [PATCH -next] snic: simplify the return expression of svnic_cq_alloc Liu Shixin
2020-10-08 2:36 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®