From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Calvin Owens <calvinowens@fb.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()
Date: Thu, 28 Jul 2016 21:23:26 -0400 [thread overview]
Message-ID: <yq1popx2q5t.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <617c5fc1-ecc5-c825-ecb9-eeae2b637dfd@fb.com> (Calvin Owens's message of "Wed, 27 Jul 2016 18:04:12 -0700")
>>>>> "Calvin" == Calvin Owens <calvinowens@fb.com> writes:
>> Any thoughts? Squinting at this more it still seems racy, but a
>> narrow race is surely better than just blatantly freeing everything
>> while the file is still exposed in /sys? Is there a better way you'd
>> prefer I accomplish this?
>>
>> (I have boxes that OOPS all the time from monitoring code reading the
>> /sys files, with this patch I haven't seen a single one.)
Calvin> Ping? Thoughts, comments?
James: This is your puppy...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-07-29 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:28 Calvin Owens
2016-06-02 22:50 ` Calvin Owens
2016-06-15 20:24 ` Calvin Owens
2016-07-28 1:04 ` Calvin Owens
2016-07-29 1:23 ` Martin K. Petersen [this message]
2016-08-12 17:45 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1popx2q5t.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=calvinowens@fb.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome