* [PATCH] aic94xx: Add missing error code assignment before test
@ 2016-08-09 11:30 Christophe JAILLET
2016-08-26 3:24 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2016-08-09 11:30 UTC (permalink / raw)
To: jejb, martin.petersen
Cc: linux-scsi, linux-kernel, kernel-janitors, Christophe JAILLET
It is likely that checking the result of 'pci_write_config_dword' is
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/scsi/aic94xx/aic94xx_hwi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic94xx/aic94xx_hwi.c b/drivers/scsi/aic94xx/aic94xx_hwi.c
index 0fdc98b..7c713f7 100644
--- a/drivers/scsi/aic94xx/aic94xx_hwi.c
+++ b/drivers/scsi/aic94xx/aic94xx_hwi.c
@@ -632,7 +632,7 @@ int asd_init_hw(struct asd_ha_struct *asd_ha)
pci_name(asd_ha->pcidev));
return err;
}
- pci_write_config_dword(asd_ha->pcidev, PCIC_HSTPCIX_CNTRL,
+ err = pci_write_config_dword(asd_ha->pcidev, PCIC_HSTPCIX_CNTRL,
v | SC_TMR_DIS);
if (err) {
asd_printk("couldn't disable split completion timer of %s\n",
--
2.7.4
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] aic94xx: Add missing error code assignment before test
2016-08-09 11:30 [PATCH] aic94xx: Add missing error code assignment before test Christophe JAILLET
@ 2016-08-26 3:24 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2016-08-26 3:24 UTC (permalink / raw)
To: Christophe JAILLET
Cc: jejb, martin.petersen, linux-scsi, linux-kernel, kernel-janitors
>>>>> "Christophe" == Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
Christophe> It is likely that checking the result of
Christophe> 'pci_write_config_dword' is expected here.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-26 3:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-09 11:30 [PATCH] aic94xx: Add missing error code assignment before test Christophe JAILLET
2016-08-26 3:24 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®