* [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr()
@ 2026-04-08 18:28 Thomas Weißschuh
2026-04-08 19:30 ` John Garry
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Weißschuh @ 2026-04-08 18:28 UTC (permalink / raw)
To: John Garry, Jason Yan, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Thomas Weißschuh
These macros are unused and to_dev_attr() will conflict with an upcoming
centralization of general attribute macros.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/scsi/libsas.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
index e76f5744941b..163f23c92b41 100644
--- a/include/scsi/libsas.h
+++ b/include/scsi/libsas.h
@@ -62,10 +62,6 @@ enum discover_event {
/* ---------- Expander Devices ---------- */
-#define to_dom_device(_obj) container_of(_obj, struct domain_device, dev_obj)
-#define to_dev_attr(_attr) container_of(_attr, struct domain_dev_attribute,\
- attr)
-
enum routing_attribute {
DIRECT_ROUTING,
SUBTRACTIVE_ROUTING,
---
base-commit: 3036cd0d3328220a1858b1ab390be8b562774e8a
change-id: 20260408-libsas-cleanup-336a5ba32c15
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr()
2026-04-08 18:28 [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr() Thomas Weißschuh
@ 2026-04-08 19:30 ` John Garry
2026-04-09 1:56 ` Martin K. Petersen
2026-04-14 2:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2026-04-08 19:30 UTC (permalink / raw)
To: Thomas Weißschuh, Jason Yan, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 08/04/2026 19:28, Thomas Weißschuh wrote:
> These macros are unused and to_dev_attr() will conflict with an upcoming
> centralization of general attribute macros.
>
> Signed-off-by: Thomas Weißschuh<linux@weissschuh.net>
Reviewed-by: John Garry <john.g.garry@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr()
2026-04-08 18:28 [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr() Thomas Weißschuh
2026-04-08 19:30 ` John Garry
@ 2026-04-09 1:56 ` Martin K. Petersen
2026-04-14 2:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2026-04-09 1:56 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: John Garry, Jason Yan, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, linux-kernel
Thomas,
> These macros are unused and to_dev_attr() will conflict with an
> upcoming centralization of general attribute macros.
Applied to 7.1/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr()
2026-04-08 18:28 [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr() Thomas Weißschuh
2026-04-08 19:30 ` John Garry
2026-04-09 1:56 ` Martin K. Petersen
@ 2026-04-14 2:19 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2026-04-14 2:19 UTC (permalink / raw)
To: John Garry, Jason Yan, James E.J. Bottomley, Thomas Weißschuh
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Wed, 08 Apr 2026 20:28:00 +0200, Thomas Weißschuh wrote:
> These macros are unused and to_dev_attr() will conflict with an upcoming
> centralization of general attribute macros.
>
>
Applied to 7.1/scsi-queue, thanks!
[1/1] scsi: libsas: Delete unused to_dom_device() and to_dev_attr()
https://git.kernel.org/mkp/scsi/c/1a2f61970a63
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-14 2:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-08 18:28 [PATCH] scsi: libsas: Delete unused to_dom_device() and to_dev_attr() Thomas Weißschuh
2026-04-08 19:30 ` John Garry
2026-04-09 1:56 ` Martin K. Petersen
2026-04-14 2:19 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®