* [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST
@ 2024-02-07 14:56 Lukas Bulwahn
2024-02-07 15:37 ` michael.christie
2024-02-13 1:37 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2024-02-07 14:56 UTC (permalink / raw)
To: Mike Christie, Christoph Hellwig, Martin K . Petersen,
James E . J . Bottomley, linux-scsi
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 25a1f7a0a1fe ("scsi: core: Add kunit tests for
scsi_check_passthrough()") adds the config SCSI_LIB_KUNIT_TEST and
corresponding tests. Due to naming confusion, the actual tests would only
be included when the non-existing config SCSI_KUNIT_TEST is enabled (note
this missing 'LIB' in the config name). So, they are basically dead right
now.
Adjust the name to actual existing config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/scsi/scsi_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 23719b903259..0315a0dc3406 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -3428,6 +3428,6 @@ void scsi_build_sense(struct scsi_cmnd *scmd, int desc, u8 key, u8 asc, u8 ascq)
}
EXPORT_SYMBOL_GPL(scsi_build_sense);
-#ifdef CONFIG_SCSI_KUNIT_TEST
+#ifdef CONFIG_SCSI_LIB_KUNIT_TEST
#include "scsi_lib_test.c"
#endif
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST
2024-02-07 14:56 [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST Lukas Bulwahn
@ 2024-02-07 15:37 ` michael.christie
2024-02-13 1:37 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: michael.christie @ 2024-02-07 15:37 UTC (permalink / raw)
To: Lukas Bulwahn, Christoph Hellwig, Martin K . Petersen,
James E . J . Bottomley, linux-scsi
Cc: kernel-janitors, linux-kernel
On 2/7/24 8:56 AM, Lukas Bulwahn wrote:
> Commit 25a1f7a0a1fe ("scsi: core: Add kunit tests for
> scsi_check_passthrough()") adds the config SCSI_LIB_KUNIT_TEST and
> corresponding tests. Due to naming confusion, the actual tests would only
> be included when the non-existing config SCSI_KUNIT_TEST is enabled (note
> this missing 'LIB' in the config name). So, they are basically dead right
> now.
>
> Adjust the name to actual existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/scsi/scsi_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 23719b903259..0315a0dc3406 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -3428,6 +3428,6 @@ void scsi_build_sense(struct scsi_cmnd *scmd, int desc, u8 key, u8 asc, u8 ascq)
> }
> EXPORT_SYMBOL_GPL(scsi_build_sense);
>
> -#ifdef CONFIG_SCSI_KUNIT_TEST
> +#ifdef CONFIG_SCSI_LIB_KUNIT_TEST
> #include "scsi_lib_test.c"
> #endif
I tried to sneak a rename in last minute and messed that up. Thanks.
Reviewed-by: Mike Christie <michael.christie@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST
2024-02-07 14:56 [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST Lukas Bulwahn
2024-02-07 15:37 ` michael.christie
@ 2024-02-13 1:37 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-02-13 1:37 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Mike Christie, Christoph Hellwig, Martin K . Petersen,
James E . J . Bottomley, linux-scsi, kernel-janitors,
linux-kernel
Lukas,
> Commit 25a1f7a0a1fe ("scsi: core: Add kunit tests for
> scsi_check_passthrough()") adds the config SCSI_LIB_KUNIT_TEST and
> corresponding tests. Due to naming confusion, the actual tests would only
> be included when the non-existing config SCSI_KUNIT_TEST is enabled (note
> this missing 'LIB' in the config name). So, they are basically dead right
> now.
>
> Adjust the name to actual existing config.
Applied to 6.9/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-13 1:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-07 14:56 [PATCH] scsi: core: really include kunit tests with SCSI_LIB_KUNIT_TEST Lukas Bulwahn
2024-02-07 15:37 ` michael.christie
2024-02-13 1:37 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®