* [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging
@ 2025-06-16 18:19 Alok Tiwari
2025-06-16 22:04 ` Martin K. Petersen
2025-06-17 6:26 ` John Garry
0 siblings, 2 replies; 3+ messages in thread
From: Alok Tiwari @ 2025-06-16 18:19 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi, linux-nvme
Cc: alok.a.tiwari, linux-kernel, darren.kenny
Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
printed twice instead of cdw15. This fix ensures accurate logging of
the full passthrough command payload.
Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
Is it ok to keep Fixes tag for this fix?
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 92697f98c601..f3e07cb92385 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -386,7 +386,7 @@ static void nvme_log_err_passthru(struct request *req)
nr->cmd->common.cdw12,
nr->cmd->common.cdw13,
nr->cmd->common.cdw14,
- nr->cmd->common.cdw14);
+ nr->cmd->common.cdw15);
}
enum nvme_disposition {
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging
2025-06-16 18:19 [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging Alok Tiwari
@ 2025-06-16 22:04 ` Martin K. Petersen
2025-06-17 6:26 ` John Garry
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2025-06-16 22:04 UTC (permalink / raw)
To: Alok Tiwari
Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel, darren.kenny
Alok,
> Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
> printed twice instead of cdw15. This fix ensures accurate logging of
> the full passthrough command payload.
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging
2025-06-16 18:19 [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging Alok Tiwari
2025-06-16 22:04 ` Martin K. Petersen
@ 2025-06-17 6:26 ` John Garry
1 sibling, 0 replies; 3+ messages in thread
From: John Garry @ 2025-06-17 6:26 UTC (permalink / raw)
To: Alok Tiwari, kbusch, axboe, hch, sagi, linux-nvme
Cc: linux-kernel, darren.kenny
On 16/06/2025 19:19, Alok Tiwari wrote:
> Fix an error in nvme_log_err_passthru() where cdw14 was incorrectly
> printed twice instead of cdw15. This fix ensures accurate logging of
> the full passthrough command payload.
>
> Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
> Is it ok to keep Fixes tag for this fix?
> ---
> drivers/nvme/host/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 92697f98c601..f3e07cb92385 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -386,7 +386,7 @@ static void nvme_log_err_passthru(struct request *req)
> nr->cmd->common.cdw12,
> nr->cmd->common.cdw13,
> nr->cmd->common.cdw14,
> - nr->cmd->common.cdw14);
> + nr->cmd->common.cdw15);
Apart from the fix, any reason not to use le32_to_cpu() when getting
these values? AFAICS, they are __le32 type
> }
>
> enum nvme_disposition {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-17 6:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-16 18:19 [PATCH] nvme: Fix incorrect cdw15 value in passthru error logging Alok Tiwari
2025-06-16 22:04 ` Martin K. Petersen
2025-06-17 6:26 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®